Rudra-G-23 opened a new pull request, #4149:
URL: https://github.com/apache/iggy/pull/4149

   ## Which issue does this PR address?
   
   Closes #4143
   
   Relates to #
   
   ## Rationale
   
   The server rejects unknown environment variables using the broad `IGGY_` 
prefix. This also rejects valid variables belonging to sibling Iggy binaries, 
such as connectors, MCP, and CLI variables, which can prevent the server from 
booting in shared environments or when these variables are loaded from a `.env` 
file.
   
   ## What changed?
   
   - Added support for allowed sibling environment-variable prefixes so 
`IGGY_CONNECTORS_*` and `IGGY_MCP_*` variables are not treated as unknown 
server configuration.
   
   - Added the CLI environment variables `IGGY_HOME`, `IGGY_USERNAME`, and 
`IGGY_PASSWORD` to the accepted process environment variables.
   
   - Improved the unknown-variable error message to include a remediation hint.
   
   - Removed the two `#[ignore]` attributes and serialized tests that mutate 
the process environment.
   
   ## Local Execution
   
   Passed.
   
   ```text
   cargo test -p configs --lib
   
   256 passed; 0 failed; 0 ignored
   ```
   
   Also ran:
   
   ```text
   cargo fmt
   git diff --check
   ```
   
   Both completed successfully.
   
   ## Pre-commit hooks
   
   Not run separately. Formatting, library tests, and `git diff --check` were 
run manually.
   
   ## AI Usage
   
   AI was used to help understand the issue, suggest implementation approaches, 
and review test failures and the final diff. I manually reviewed the changes, 
applied the edits, and ran the local tests and checks before committing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to