mattp5657 opened a new pull request, #4158:
URL: https://github.com/apache/iggy/pull/4158
## Which issue does this PR address?
Closes #4157
## What changed?
`normalize_host` detected the URL scheme via a literal
`starts_with("http://";)`/`starts_with("https://";)` check. An uppercase or
mixed-case scheme like `HTTPS://host` matched neither literal, fell through to
the "no scheme" branch, and got `http://` prepended, producing
`http://HTTPS://host`, which parses as `scheme="http"`, `host="https"`,
silently connecting to the wrong host over plaintext.
Scheme detection is now case-insensitive (`eq_ignore_ascii_case` on the
split-off scheme), matching `opensearch_sink`'s existing pattern. An
unsupported scheme (e.g. `ftp://`) is now also rejected outright instead of
being silently mangled the same way.
## Local Execution
- Passed
- Pre-commit hooks ran
## AI Usage
Claude was used in creating this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
