mlevkov commented on PR #4064: URL: https://github.com/apache/iggy/pull/4064#issuecomment-5648258649
All 11 addressed and each one answered on its own thread. Four commits: the failed-open rollback, the stats-wait fixes, the guard and start window, and the naming and prose pass. Two things I did not decide on my own, both on their threads and repeated here so they are not missed: **`manager/source.rs:92`** in the S2 comment does not land on cleanup prose in the current head; it is inside `set_error`, the gauge transition comment. The branch has taken master three times since you looked, so I think the anchor drifted. I consolidated at `source.rs:319` and trimmed the two call-site comments in `manager/source.rs` that do repeat the argument. Point me at the right line if I missed one. **The `record_started` closure** arrived as `0c4b859f8 fix(connectors): make an await in the start window a compile error` — passing the spawn into a non-async fn is what made the compiler refuse an await between the spawn and the id record. Your note says to keep that property knowing the compiler stops enforcing it, so I inlined it and wrote the requirement where the statements now are. Flagging the commit in case it changes your mind. One thing beyond what you asked: **`iggy_sink_open` had the same unconditional insert as the source**, so a failed sink open stranded an instance the same way. Fixed alongside. Happy to split it out if you would rather it rode separately. 213 runtime and 165 SDK unit tests pass, and all 26 `connectors::random` and `connectors::runtime` integration tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
