spetz commented on code in PR #4151: URL: https://github.com/apache/iggy/pull/4151#discussion_r3997702331
########## examples/go/getting-started/consumer/main_test.go: ########## @@ -0,0 +1,89 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package main + +import ( + "context" + "slices" + "strconv" + "testing" + "time" + + iggcon "github.com/apache/iggy/foreign/go/contracts" +) + +func TestConsumeMessagesAdvancesPastRetainedMessages(t *testing.T) { Review Comment: Never executed. The Go test lane runs `go test` only under `foreign/go` (`.github/actions/go/pre-merge/action.yml:75`), `examples/go` gets golangci-lint alone, and the examples runner filters README commands on `^go run` (`scripts/run-examples-from-readme.sh:250`) with no `go test` line in `examples/go/README.md`. golangci-lint type-checks the file, so it compiles and nothing more. ########## web/src/lib/utils/base64Utils.test.mjs: ########## @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +import assert from 'node:assert/strict'; +import { test } from 'node:test'; +import { decodeBase64 } from './base64Utils.ts'; + +test('decode message payloads as UTF-8 text', () => { Review Comment: Never executed. `web/package.json` has no `test` script, and the web CI job runs only `npm run lint` or `npm run build` (`.github/workflows/_test.yml:265`). This is the only test file under `web/`. ########## examples/java/build.gradle.kts: ########## @@ -30,6 +30,12 @@ dependencies { implementation("org.apache.iggy:iggy:local-dev") implementation("org.slf4j:slf4j-simple:2.0.18") implementation("tools.jackson.core:jackson-databind:3.2.2") + testImplementation(platform(libs.junit.bom)) + testImplementation(libs.bundles.testing) +} + +tasks.test { Review Comment: The new `tasks.test { useJUnitPlatform() }` wiring plus `ConsumerOffsetTest` and `MultiTenantAccessTest` never compile or run. `./gradlew test` runs only in `foreign/java` (`.github/actions/java-gradle/pre-merge/action.yml:99`), the examples lint lane runs `./gradlew check -x test` (line 48), and with no checkstyle plugin in this build nothing else pulls in `compileTestJava`. The README-driven runner greps `'^\./gradlew'` against `examples/java/README.md`, which has no test invocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
