jiengup opened a new pull request, #4162:
URL: https://github.com/apache/iggy/pull/4162
## Which issue does this PR address?
Closes #4161
## Rationale
README example commands split with shell line continuations were executed
without their continuation lines, causing CI failures or behavior different
from the documented command.
## What changed?
`run_readme_commands` previously filtered physical README lines before
execution, so arguments on continuation lines were discarded. README lines are
now combined into logical shell commands before include/exclude matching,
transformation, and execution, while escaped trailing backslashes remain
unchanged. The existing Rust HTTP example commands use continuation lines so
the examples CI lane exercises this behavior.
## Local Execution
- Passed:
- Focused shell regression tests covering multiline execution,
include/exclude matching, transformations, timeout execution, command counting,
and odd/even trailing backslashes
- `prek run --files scripts/utils.sh examples/rust/README.md`
- `./scripts/ci/shellcheck.sh --check`
- `./scripts/ci/markdownlint.sh --check`
- `bash -n scripts/utils.sh scripts/run-examples-from-readme.sh`
- `git diff --check upstream/master...HEAD`
- `cargo clippy --all-features --all-targets --manifest-path Cargo.toml --
-D warnings`
- Pre-commit and pre-push hooks ran
## AI Usage
1. Which tools? OpenAI Codex.
2. Scope of usage? Issue analysis and creation, implementation, focused
regression testing, validation, and drafting this PR description.
3. How did you verify the generated code works correctly? I ran focused
shell tests for continuation parsing and command execution, the repository
pre-commit checks, full ShellCheck and Markdown lint checks, and the full
workspace Clippy pre-push hook.
4. Can you explain every line of the code if asked? Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
