ryerraguntla commented on code in PR #4043:
URL: https://github.com/apache/iggy/pull/4043#discussion_r4001642074
##########
gateways/kafka/src/main.rs:
##########
@@ -186,15 +222,22 @@ async fn shutdown_signal() {
#[cfg(test)]
mod tests {
+ use serial_test::serial;
+
use super::{parse_positive, reject_unknown_kafka_env_vars};
- /// Sequential (not two separate `#[test]` fns) so the two env-var
mutations can't race
- /// against each other under the test harness's default parallel execution
- env vars are
- /// process-global state.
+ /// Sequential (not two separate `#[test]` fns), and `#[serial]` (unkeyed
- the whole binary's
+ /// default group, shared with `bridge::config`'s and `server`'s
env-touching tests).
Review Comment:
**Fixed** both this one and the mirror-image claim on
server.rs:init_tracing_is_idempotent has the same bug in reverse - corrected
both to state their actual (and different) serial-group membership.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
