numinnex commented on code in PR #4194:
URL: https://github.com/apache/iggy/pull/4194#discussion_r4018011070
##########
core/consensus/src/impls.rs:
##########
@@ -1198,9 +1198,9 @@ where
timeouts: RefCell<TimeoutManager>,
- /// Monotonic timestamp from the most recent accepted commit heartbeat.
- /// Old/replayed commit messages with a lower timestamp are ignored.
- heartbeat_timestamp: Cell<u64>,
+ /// View and counter of the last emitted or accepted heartbeat. A new
+ /// primary's counter can be lower, so freshness is scoped to its view.
Review Comment:
Maybe if we received a lower timestamp than the previous one, we can instead
take max(current, new). In the VSR when message with a strictly non monotonic
StartViewChange/DoViewChange is received, the default mode is to assume that
it's the correct view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
