diegomrsantos opened a new pull request, #4203: URL: https://github.com/apache/iggy/pull/4203
## Which issue does this PR address? No linked issue. ## Rationale With `poll-diagnostics` disabled, Clippy reports `needless_pass_by_ref_mut` for `read_chunk_with_retry`. Its `&mut DiskWalk` parameter is needed to update the diagnostic counters when the feature is enabled. ## What changed? Allow this lint on the helper only when `poll-diagnostics` is disabled, with an inline reason explaining why the mutable reference is intentional. ## Local Execution Passed on macOS: - `cargo clippy --workspace --all-targets --locked -- -D warnings` - `cargo clippy --workspace --all-features --all-targets --locked -- -D warnings` - `cargo test -p partitions --all-features --locked --quiet`: 307 passed, 3 ignored. - Rust formatting, Cargo dependency sorting, and TOML formatting checks. Git hooks are not installed in this checkout, so they did not run. Taplo ran directly because the repository wrapper requires Bash 4.2 or newer. ## AI Usage Codex assisted with diagnosing the warning, implementing and reviewing the conditional allowance, and running the checks above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
