justinmclean commented on code in PR #4050:
URL: https://github.com/apache/iggy/pull/4050#discussion_r4031918773


##########
core/journal/src/file_storage.rs:
##########
@@ -200,6 +206,9 @@ mod tests {
     /// Pins the synchronous truncate signature and verifies it works inside a
     /// shard executor with no blocking pool. A modern test kernel supports
     /// `IORING_OP_FTRUNCATE`, so this does not reproduce compio's fallback.
+    /// Unix-only: `create_shard_executor` keeps the zero blocking-pool limit
+    /// on io_uring targets only, so the premise does not hold elsewhere.

Review Comment:
   io_uring needs backticks here, which is what the clippy job is failing on.
   
   ```suggestion
       /// on `io_uring` targets only, so the premise does not hold elsewhere.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to