mmmmxa opened a new pull request, #4219: URL: https://github.com/apache/iggy/pull/4219
## Which issue does this PR address? Closes #3839 Relates to #4105 ## Rationale The current Delta connector implementation does not allow to properly set up a sink and does not provide user with helpful guidance on how to do so. ## What changed? Before: - S3 storage type mandates access key and secret key, while this practice is discouraged by AWS. - The existence of the destination delta table is not checked and docs don't mention that. - `aws_s3_endpoint_url` may conflict with a region setting and its use is not necessary unless it's used with minio locally or with non AWS S3 compatible storage. - Documentation does not help the user to set up the sink. - The comment about the lock does not make sense for the uses of this connector, see #3839 for more info. After: - Stopped mandating the S3 access and secret keys. Mentioned the two access options in the docs. Suggested the sufficient policy configuration to be given to the instance. - Checking the table existence after opening, wrote a test for it. - Documented the usage of `aws_s3_endpoint_url` configuration setting. - Added detailed information on how to set up the connector properly. - Comment on the lock was deleted to stop causing confusion. ## Local Execution - Passed - Pre-commit hooks ran / not ran ## AI Usage <!-- If AI tools were used, please answer: 1. Which tools? (e.g., GitHub Copilot, Claude, ChatGPT) 2. Scope of usage? (e.g., autocomplete, generated functions, entire implementation) 3. How did you verify the generated code works correctly? 4. Can you explain every line of the code if asked? If no AI tools were used, write "None" or delete this section. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
