justinmclean commented on PR #4212: URL: https://github.com/apache/iggy/pull/4212#issuecomment-5723724408
Thanks for checking the document by hand, especially the request bodies, but it would be good if you could run cargo test. Guarding the bodies is out of scope for this PR. Deriving schemas from the Rust types would add a new server dependency, and it would still miss hand-written deserialisers like SendMessages. Good catch on is_cfg_test. I'll change it to skip only #[cfg(test)]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
