justinmclean commented on issue #2883: URL: https://github.com/apache/iggy/issues/2883#issuecomment-5754026072
Checked `foreign/go/internal/command` against the current tree. 44 command types implement `MarshalBinary`, and 11 of them are exercised by a test. The remaining 33 are not, grouped by the file they live in: - `access_token.go`: `CreatePersonalAccessToken`, `DeletePersonalAccessToken`, `GetPersonalAccessTokens` - `consumer_group.go`: `CreateConsumerGroup`, `DeleteConsumerGroup`, `GetConsumerGroup`, `GetConsumerGroups`, `JoinConsumerGroup`, `LeaveConsumerGroup`, `SyncConsumerGroup` - `offset.go`: `DeleteConsumerOffset`, `GetConsumerOffset`, `StoreConsumerOffsetRequest` - `partition.go`: `CreatePartitions`, `DeletePartitions` - `session.go`: `LoginWithPersonalAccessToken`, `LogoutUser` - `stream.go`: `DeleteStream`, `GetStream`, `GetStreams` - `system.go`: `DescribeOptions`, `GetClient`, `GetClients`, `GetClusterMetadata`, `GetStats`, `Ping` - `topic.go`: `DeleteTopic`, `GetTopic`, `GetTopics` - `user.go`: `ChangePassword`, `DeleteUser`, `GetUser`, `GetUsers` The ones already covered are `CreateStream`, `UpdateStream`, `CreateTopic`, `UpdateTopic`, `CreateUser`, `UpdateUser`, `UpdatePermissions`, `LoginUser`, `SendMessages`, `PollMessages` and `DeleteSegments`, in `stream_test.go`, `topic_test.go`, `update_user_test.go`, `session_test.go`, `message_test.go` and `segment_test.go`. Those are the pattern to copy. One file is a self-contained piece of work, so this is worth picking up a file at a time rather than all 33 at once. `system.go` is the easiest start: six types, most of them taking no arguments. Counted by matching `MarshalBinary` receivers against type names appearing in the `_test.go` files, so a type that is referenced but not actually asserted on would show as covered. Treat the 33 as a floor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
