This is an automated email from the ASF dual-hosted git repository.
hubcio pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iggy.git
The following commit(s) were added to refs/heads/master by this push:
new 9a59f7857 ci(rust): run clippy on macOS so cfg(target_os) code gets
linted (#4248)
9a59f7857 is described below
commit 9a59f785778f85ce5f599373e3c63dd57ae125c6
Author: Hubert Gruszecki <[email protected]>
AuthorDate: Mon Sep 21 11:31:12 2026 +0200
ci(rust): run clippy on macOS so cfg(target_os) code gets linted (#4248)
---
.github/actions/rust/pre-merge/action.yml | 7 +++++--
.github/config/components.yml | 1 +
.github/workflows/_test.yml | 2 +-
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/.github/actions/rust/pre-merge/action.yml
b/.github/actions/rust/pre-merge/action.yml
index 8b3413b79..5bbd0b0e4 100644
--- a/.github/actions/rust/pre-merge/action.yml
+++ b/.github/actions/rust/pre-merge/action.yml
@@ -20,7 +20,7 @@ description: Rust pre-merge testing and linting github iggy
actions
inputs:
task:
- description: "Task to run (check, check-msrv, fmt, clippy, sort, machete,
doctest, verify-publish, test-1, test-2, test-3, test-storage-compat, miri)"
+ description: "Task to run (check, check-msrv, fmt, clippy,
clippy-macos-aarch64, sort, machete, doctest, verify-publish, test-1, test-2,
test-3, test-storage-compat, miri)"
required: true
component:
description: "Component name (for context)"
@@ -213,8 +213,11 @@ runs:
run: cargo fmt --all -- --check
shell: bash
+ # clippy-macos-aarch64 runs the same lint on macos-14. Code behind
+ # cfg(target_os) splits is dead to the Linux leg, so its warnings would
+ # otherwise reach master unseen.
- name: Cargo clippy
- if: inputs.task == 'clippy'
+ if: inputs.task == 'clippy' || inputs.task == 'clippy-macos-aarch64'
run: cargo clippy --all-targets --all-features -- -D warnings
shell: bash
diff --git a/.github/config/components.yml b/.github/config/components.yml
index a45baf7ed..9ed475e6c 100644
--- a/.github/config/components.yml
+++ b/.github/config/components.yml
@@ -218,6 +218,7 @@ components:
- "build-aarch64-gnu"
- "build-aarch64-musl"
- "build-macos-aarch64"
+ - "clippy-macos-aarch64"
- "build-windows-sdk"
# CLI component
diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml
index 6e0f2b563..8b1353afe 100644
--- a/.github/workflows/_test.yml
+++ b/.github/workflows/_test.yml
@@ -42,7 +42,7 @@ jobs:
# Select runner based on build target
runs-on: ${{
(inputs.task == 'build-aarch64-gnu' || inputs.task ==
'build-aarch64-musl') && 'ubuntu-24.04-arm' ||
- inputs.task == 'build-macos-aarch64' && 'macos-14' ||
+ (inputs.task == 'build-macos-aarch64' || inputs.task ==
'clippy-macos-aarch64') && 'macos-14' ||
inputs.task == 'build-windows-sdk' && 'windows-latest' ||
'ubuntu-latest'
}}
