hubcio commented on code in PR #4180:
URL: https://github.com/apache/iggy/pull/4180#discussion_r4064822155


##########
foreign/cpp/include/iggy.hpp:
##########
@@ -275,12 +389,185 @@ class HeaderEntry final {
 
     static HeaderEntry FromFfi(ffi::HeaderEntry entry);
 
+    friend class IggyMessagePolled;
     friend class ResourceOptions;
 
     HeaderField key_;
     HeaderField value_;
 };
 
+/**
+ * @brief Message payload and user headers prepared for sending.
+ *
+ * Create() owns the supplied payload and headers. Validation is deferred until
+ * the message is sent. A valid payload contains between 1 and 64,000,000 
bytes,
+ * and the encoded user headers occupy no more than 100,000 bytes. Header keys
+ * must be unique. Header insertion order is not preserved during transmission;
+ * headers are ordered by their typed keys.
+ *
+ * The message ID is application-defined and defaults to zero. IDs do not need
+ * to be unique.
+ */
+class IggyMessageToSend final {

Review Comment:
   for both, but we can leave it as is now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to