goutamadwant opened a new pull request, #4305: URL: https://github.com/apache/iggy/pull/4305
## Which issue does this PR address? Relates to #2883 ## Rationale The six system commands did not have direct assertions for their serialized request bodies. Literal byte checks will catch changes that break the server's expected binary format. ## What changed? Added tests for the little-endian `GetClient` ID, valid and invalid `DescribeOptions` scopes, and the empty bodies of `GetClients`, `GetClusterMetadata`, `GetStats`, and `Ping`. No production code changed. ## Local Execution - Passed: `go test ./...` - Passed: `go test -race ./internal/command` - Passed: `go vet ./...` - Passed: Go lint via `prek run --last-commit --stage pre-push` - Pre-commit: `prek run --last-commit` ran, but the license-header hook could not run because HawkEye 7.0.1 is not installed. All other applicable hooks passed. This check remains pending before submission. ## AI Usage 1. Tool: Codex 2. Scope: assisted with drafting the tests and checking expected bytes against the Rust request definitions. 3. Verification: the Go tests, race test, vet, and lint listed above were run locally; the expected byte layouts were reviewed against the Rust protocol code. 4. Yes. I have reviewed the change and can explain each assertion and its corresponding wire layout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
