github-actions[bot] commented on code in PR #4302:
URL: https://github.com/apache/iggy/pull/4302#discussion_r4126791250
##########
core/connectors/sources/http_source/src/lib.rs:
##########
@@ -905,7 +908,7 @@ impl HttpSource {
///
/// A batch that can never be delivered would replay forever, but this
/// connector rejects malformed work at the door rather than mid-stream:
- /// oversized bodies get 413 before a handler runs, headers are clamped on
+ /// an empty body gets 400 and an oversized one 413, headers are clamped on
Review Comment:
nit: `forward_headers` has no cap, so clamped headers can still wedge a
batch: a few hundred forwarded names push a message past Iggy's 100000-byte
user-header limit. The runtime then NACKs the whole batch on every replay. Cap
the list in `validate()`, as `endpoints` is capped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
