RustToMetal commented on code in PR #4306:
URL: https://github.com/apache/iggy/pull/4306#discussion_r4127716959
##########
foreign/swift/Tests/IggyTests/ErrorCodeTests.swift:
##########
@@ -39,6 +39,17 @@ struct ErrorCodeTests {
#expect(Set(IggyErrorCode.allCases.map(\.name)).count ==
IggyErrorCode.allCases.count)
}
+ /// The full table, against the dump the Rust generator takes from the
+ /// server's error enum.
+ @Test func errorCodesMatchTheServerTable() {
Review Comment:
Done, dropped the count, min and max pins and kept the named spot checks.
##########
.github/config/components.yml:
##########
@@ -346,9 +346,10 @@ components:
- "bdd/swift/**"
- "examples/swift/**"
# The SDK compiles against the VSR wire contract, so a change to the
- # protocol crate must rerun it.
+ # protocol crates must rerun it and regenerate the golden vectors.
- "core/binary_protocol/**"
- tasks: ["lint", "test", "build", "build-macos"]
+ - "core/common/**"
Review Comment:
Done, both paths and the comment are gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
