justinmclean opened a new issue, #4330:
URL: https://github.com/apache/iggy/issues/4330

   The Rust client has `ConsumerOffsetClient::delete_consumer_offset` 
(`core/common/src/traits/consumer_offset_client.rs`). The Java SDK has 
`storeConsumerOffset` and `getConsumerOffset`, but not delete.
   
   ## What to do
   
   - Add `DELETE(122)` to the `ConsumerOffset` enum in 
`serde/CommandCode.java`. The VSR operation is already mapped in 
`VsrOperation.java`.
   - Add `deleteConsumerOffset` to the blocking and async 
`ConsumerOffsetsClient` interfaces, with the same arguments as 
`getConsumerOffset` and no return value.
   - Implement it in the TCP clients 
(`client/async/tcp/ConsumerOffsetsTcpClient.java`, 
`client/blocking/tcp/ConsumerOffsetsTcpClient.java`) and the HTTP client 
(`client/blocking/http/ConsumerOffsetsHttpClient.java`), following 
`getConsumerOffset`.
   - Add a test to `ConsumerOffsetsClientBaseTest.java` that stores an offset, 
deletes it, and checks that `getConsumerOffset` then returns empty. The base 
test runs for both TCP and HTTP.
   
   ## Done when
   
   The new test passes for both the TCP and HTTP clients.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to