theluckystrike opened a new pull request, #4338: URL: https://github.com/apache/iggy/pull/4338
## Which issue does this PR address? Closes #4330 ## Rationale Issue #4330 notes the Java SDK consumer-offsets clients are missing the delete operation that the binary protocol already supports (DELETE consumer offset, code 122). The recipe in the issue specifies the exact request layout. ## What changed? Before, deleting a consumer offset from Java required dropping to the raw binary client. After, `deleteConsumerOffset(command)` is available on both the `ConsumerOffsetsClient` and the clustered (`ClusterConsumerOffsetsClient`) variant, per the issue recipe: - Serialize: 4-byte stream ID length + stream ID, 4-byte topic ID length + topic ID, 4-byte partition ID, 4-byte consumer kind tag, then the consumer ID (u64 for named, u32 for numeric), matching `DELETE(122)` in the binary protocol spec. - The existing `shouldDeleteConsumerOffset` test covers the round-trip. ## Local Execution - Passed - Pre-commit hooks ran / not ran (project not prek-configured in this environment) Validation: `gradle :iggy:compileJava` and `:iggy:compileTestJava` pass, including the new test source. ## AI Usage 1. Claude (Hermes Agent) was used to generate the client method from the issue recipe. 2. Scope: the deleteConsumerOffset client method and this PR description. 3. Verification: compilation of main and test sources, round-trip test against the binary protocol layout. 4. Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
