codecov[bot] commented on PR #4345: URL: https://github.com/apache/iggy/pull/4345#issuecomment-5891379293
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4345?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `80.78049%` with `197 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 75.25%. Comparing base ([`9fdb642`](https://app.codecov.io/gh/apache/iggy/commit/9fdb64274c6b36dbb058713e66fd82f3b68bdf83?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a589ff4`](https://app.codecov.io/gh/apache/iggy/commit/a589ff448b345c726a4c1e351a3a79318fca43eb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4345?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [core/sdk/src/tcp/tcp\_client.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Ftcp%2Ftcp_client.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL3RjcC90Y3BfY2xpZW50LnJz) | 83.46% | [86 Missing and 19 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [core/sdk/src/clients/client.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclients%2Fclient.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudHMvY2xpZW50LnJz) | 78.04% | [24 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [core/common/src/request\_budget.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Frequest_budget.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3JlcXVlc3RfYnVkZ2V0LnJz) | 76.69% | [22 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [core/common/src/traits/binary\_impls/users.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftraits%2Fbinary_impls%2Fusers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3RyYWl0cy9iaW5hcnlfaW1wbHMvdXNlcnMucnM=) | 73.68% | [3 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/sdk/src/clients/binary\_personal\_access\_tokens.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclients%2Fbinary_personal_access_tokens.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudHMvYmluYXJ5X3BlcnNvbmFsX2FjY2Vzc190b2tlbnMucnM=) | 65.38% | [6 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../src/traits/binary\_impls/personal\_access\_tokens.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftraits%2Fbinary_impls%2Fpersonal_access_tokens.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3RyYWl0cy9iaW5hcnlfaW1wbHMvcGVyc29uYWxfYWNjZXNzX3Rva2Vucy5ycw==) | 75.75% | [4 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [core/sdk/src/clients/binary\_users.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclients%2Fbinary_users.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudHMvYmluYXJ5X3VzZXJzLnJz) | 84.61% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [core/sdk/src/clients/client\_builder.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclients%2Fclient_builder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudHMvY2xpZW50X2J1aWxkZXIucnM=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [core/common/src/types/args/mod.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fargs%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL2FyZ3MvbW9kLnJz) | 25.00% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [core/common/src/traits/binary\_transport.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftraits%2Fbinary_transport.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3RyYWl0cy9iaW5hcnlfdHJhbnNwb3J0LnJz) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [2 more](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #4345 +/- ## ============================================= - Coverage 87.77% 75.25% -12.53% - Complexity 1575 1576 +1 ============================================= Files 1288 1289 +1 Lines 227249 222599 -4650 Branches 190686 186038 -4648 ============================================= - Hits 199478 167506 -31972 - Misses 23062 50152 +27090 - Partials 4709 4941 +232 ``` | [Components](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.70% <80.78%> (-15.18%)` | :arrow_down: | | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.70% <ø> (+0.01%)` | :arrow_up: | | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.41% <ø> (+0.01%)` | :arrow_up: | | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.00% <ø> (ø)` | | | [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.67% <ø> (ø)` | | | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.55% <ø> (-0.03%)` | :arrow_down: | | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4345/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.37% <ø> (+0.08%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4345?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [core/common/src/error/iggy\_error.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ferror%2Figgy_error.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL2Vycm9yL2lnZ3lfZXJyb3IucnM=) | `100.00% <ø> (ø)` | | | [...ypes/configuration/tcp\_config/tcp\_client\_config.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fconfiguration%2Ftcp_config%2Ftcp_client_config.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL2NvbmZpZ3VyYXRpb24vdGNwX2NvbmZpZy90Y3BfY2xpZW50X2NvbmZpZy5ycw==) | `100.00% <100.00%> (ø)` | | | [...figuration/tcp\_config/tcp\_client\_config\_builder.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fconfiguration%2Ftcp_config%2Ftcp_client_config_builder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL2NvbmZpZ3VyYXRpb24vdGNwX2NvbmZpZy90Y3BfY2xpZW50X2NvbmZpZ19idWlsZGVyLnJz) | `56.43% <100.00%> (-14.70%)` | :arrow_down: | | [...ration/tcp\_config/tcp\_connection\_string\_options.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fconfiguration%2Ftcp_config%2Ftcp_connection_string_options.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL2NvbmZpZ3VyYXRpb24vdGNwX2NvbmZpZy90Y3BfY29ubmVjdGlvbl9zdHJpbmdfb3B0aW9ucy5ycw==) | `82.92% <100.00%> (-3.44%)` | :arrow_down: | | [core/common/src/traits/binary\_transport.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftraits%2Fbinary_transport.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3RyYWl0cy9iaW5hcnlfdHJhbnNwb3J0LnJz) | `25.00% <75.00%> (+25.00%)` | :arrow_up: | | [core/sdk/src/client\_provider.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclient_provider.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudF9wcm92aWRlci5ycw==) | `43.33% <50.00%> (+0.09%)` | :arrow_up: | | [core/sdk/src/client\_wrappers/client\_wrapper.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclient_wrappers%2Fclient_wrapper.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudF93cmFwcGVycy9jbGllbnRfd3JhcHBlci5ycw==) | `83.33% <83.33%> (ø)` | | | [core/common/src/types/args/mod.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ftypes%2Fargs%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL3R5cGVzL2FyZ3MvbW9kLnJz) | `45.51% <25.00%> (-0.54%)` | :arrow_down: | | [core/sdk/src/clients/binary\_users.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclients%2Fbinary_users.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudHMvYmluYXJ5X3VzZXJzLnJz) | `90.90% <84.61%> (-9.10%)` | :arrow_down: | | [core/sdk/src/clients/client\_builder.rs](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclients%2Fclient_builder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudHMvY2xpZW50X2J1aWxkZXIucnM=) | `48.50% <0.00%> (-10.73%)` | :arrow_down: | | ... and [6 more](https://app.codecov.io/gh/apache/iggy/pull/4345?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [448 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4345/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
