hubcio commented on issue #4356: URL: https://github.com/apache/iggy/issues/4356#issuecomment-5909442241
i checked in code and you're right. pyo3 turns `()` into an empty tuple, and no test checks these return values. let's return `None` like the stubs say. fix 26 of them, including the three from #4166 (it can change them later). `login_user` is already covered by #4276. use one helper for all of them (and `IggyProducer.shutdown`) and add one test that calls each method and checks the result `is None`. you're on #4328 with no PR yet, so open that first (one open pr at a time). after it's merged, grab this one if you want. test and fix in one PR is fine. do you want to work on this @FenjuFu ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
