jiengup commented on code in PR #4278:
URL: https://github.com/apache/iggy/pull/4278#discussion_r4173761487
##########
core/simulator/src/storage/tests.rs:
##########
@@ -812,12 +814,14 @@ fn
given_a_failed_writeback_when_beginning_an_install_backup_should_refuse_publi
storage.sync_directory(Path::new(DIRECTORY)).await.unwrap();
storage.fail_writeback(path).unwrap();
- let result = install_backup::begin_with_storage(Path::new(DIRECTORY),
&storage).await;
+ let barrier = FileSyncBarrier::from_file(path, writer);
+ let result = install_backup::begin_with_storage_and_barriers(
Review Comment:
In the newest push, I added a failed-writeback `SimStorage` test for the
offset writer in core/simulator/src/storage/tests.rs:845 and a test that calls
the production messages writer barrier in
core/partitions/src/iggy\_partition.rs:16394. These tests are intended to fail
if either barrier is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
