ParthibanRajasekaran commented on code in PR #4350:
URL: https://github.com/apache/iggy/pull/4350#discussion_r4174153446
##########
core/server/README.md:
##########
@@ -27,7 +27,7 @@ To run one node of a cluster, pass its replica ID from the
`cluster.nodes` roste
cargo run --bin iggy-server --release -- --replica-id 0
```
-`--replica-id` is the only command line argument; everything else is
configuration.
+Command line arguments include `--replica-id`, `--fresh` (`-f`),
`--with-default-root-credentials`, and `--list-config-env-vars`; everything
else is configuration.
Review Comment:
Documented the flag and <N>, <KEY>, and <FIELD> semantics on the canonical
server, connectors runtime, and MCP website pages in apache/iggy-website#130.
The companion docs PR passed link/header checks, TypeScript, and the production
build.
##########
core/configs_derive/src/config_env.rs:
##########
@@ -359,6 +389,49 @@ fn generate_struct_impl(
}
};
+ let own_template_entries = mappings.iter().map(|mapping| {
Review Comment:
Implemented in 2a44277. EnvVarTemplate now carries config_path and
is_secret, and env_mappings() expands the compact templates through the shared
configs helper. The duplicate generated mapping walk and parity-only test are
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
