hubcio commented on code in PR #4387:
URL: https://github.com/apache/iggy/pull/4387#discussion_r4182072742
##########
core/partitions/src/iggy_partition.rs:
##########
@@ -4380,80 +4528,103 @@ where
// earned, not the typed 404 the existence check would raise now
// that the offset is gone.
//
- // A replay racing its own in-flight original is absorbed here: the
- // slice only knows committed ops, so it cannot yet see the copy
- // still in the pipeline. Keyed on the exact `(client, request)`
- // for the transports that keep several writes in flight per
- // client (HTTP handlers on one session, the pipelining SDKs):
- // matching any request from the client would serialize them to
- // one in-flight write per group. A lockstep TCP connection never
- // has a second request here to begin with.
+ // One unresolved mutation per session/group protects the original
+ // receipt until the caller resolves it. An exact pending retry is
+ // still uncertain; a different request waits for that original
+ // instead of displacing its receipt.
//
- // Those same transports can deliver a client's ids out of order:
+ // HTTP handlers and pipelining SDKs can deliver a client's ids
out of order:
// a write refused transiently here is replayed after its
// successors committed. The slice therefore keeps a committed-id
// window under the watermark (`consensus::COMMITTED_WINDOW_BITS`)
// and admits an unmarked id inside it instead of absorbing it.
if !is_auto_commit_client(client_id) {
- if
consensus.pipeline_has_message_from_client_request(client_id, request) {
+ if let Some((pending_session, pending_request,
pending_operation)) =
Review Comment:
will be fixxed in future PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
