TomPlanche commented on code in PR #4388:
URL: https://github.com/apache/iggy/pull/4388#discussion_r4188488351
##########
core/sdk/src/tcp/tcp_client.rs:
##########
@@ -645,6 +656,10 @@ impl TcpClient {
trace!("Client is already connecting.");
return Ok(());
}
+ _ if self.disconnected_by_caller.load(Ordering::SeqCst) =>
{
Review Comment:
Fixed: the sweep now checks the flag before each dial, before each retry
sleep and before installing the connection. Added a test with your scenario, it
hangs without the fix.
Note: a sweep sleeping in a pause still waits for it to end before stopping.
I can make the sleeps interruptible if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
