Mola-maker commented on issue #4463: URL: https://github.com/apache/iggy/issues/4463#issuecomment-6075975308
Hi, I would like to work on this one. Please assign it to me if it is still available. My plan, following the order in the issue: 1. In `core/cli/src/credentials.rs`, resolve the login token with precedence: an explicitly passed token/credentials flag first, then the `IGGY_TOKEN` environment variable, then the username/password pair. If `IGGY_TOKEN` is set but empty, treat it as unset. 2. Update the `--help` text for the credential options so the env var fallback and precedence are documented where users look for them. 3. Extend the CLI integration tests (`test_login_options.rs` or the closest existing login test module) with three cases: token from env only, flag overriding env, and username/password used when no token is present anywhere. 4. Run `cargo fmt`, `cargo clippy` and the CLI package tests before opening the PR. Happy to adjust the approach if you prefer a different shape. I can explain and defend every part of the change in review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
