gonappuccino opened a new pull request, #4484:
URL: https://github.com/apache/iggy/pull/4484

   Closes #4458
   
   The `-g` and `-s` help for `iggy user permissions` was copied from `user 
create`, so it talked about a "created user" and every example ran `iggy user 
create`.
   
   This updates the help to describe an existing user and switches the examples 
to `iggy user permissions`. It also notes that the command replaces the whole 
permission set: passing only `-g` drops the stream permissions, and passing 
only `-s` resets the global ones.
   
   While updating the test I noticed that `should_help_match` in 
`test_user_permissions_command.rs` was running `user create --help`, so it now 
checks `user permissions --help`. The `user create` help is unchanged.
   
   Ran locally:
   - `cargo test -p integration --test mod -- 
cli::user::test_user_permissions_command:: 
cli::user::test_user_create_command::should_help 
cli::user::test_user_create_command::should_short_help` (5 passed)
   - `cargo fmt --all -- --check`
   - `cargo clippy -p iggy-cli --all-targets -- -D warnings`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to