haubur commented on code in PR #4501:
URL: https://github.com/apache/iggy/pull/4501#discussion_r4251832361
##########
core/sdk/src/http/http_client.rs:
##########
@@ -242,7 +243,7 @@ impl HttpClient {
heartbeat_interval: config.heartbeat_interval,
access_token: IggyRwLock::new(access_token),
send_contexts: ConsumerGroupClientState::new(),
- events: broadcast(1000),
+ events: diagnostic_event_channel(),
Review Comment:
Maybe we should document that this is dead.
HTTP is stateless. The `HttpClient` implements the Client trait which has
`subscribe_events` has a required method. Thats why it exists here but
`subscribe_events` is (correctly) not implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
