choksi2212 commented on PR #4497: URL: https://github.com/apache/iggy/pull/4497#issuecomment-6133199527
The `Go • lint` run on 57ce6bb flagged a real formatting miss on my side: `gofmt -l foreign/go` is part of the lint task, and the import blocks in the files touched by 04be090/57ce6bb were not in gofmt order (most visibly the dot-import of `internal/fakevsr` sorted first instead of in place, and `crypto/tls` misplaced in the new parser test). My Windows checkout uses CRLF, which makes every file look unformatted to `gofmt -l`, so the real findings hid in the noise. d38cad2 applies exactly `gofmt -w` to the committed content of the fourteen touched files - import ordering only, no logic changes: - `gofmt -l` on the committed blobs: empty for all fourteen files (verified per-blob before pushing) - `go build ./...` and `go vet ./...`: clean - `go test -race -count=1 ./client/...`: green (client + tcp packages, fresh test cache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
