mohitduhan19 commented on issue #4492: URL: https://github.com/apache/iggy/issues/4492#issuecomment-6140975425
Hi @justinmclean, I'd like to work on this. Could you assign it to me? Plan: add `fromConnectionString(String)` to `TcpClientBuilder`, following `parseConnectionString` in the Node SDK. It will accept `iggy://` and `iggy+tcp://` with `user:password@host:port` (including `[ipv6]:port`), reject other transports such as `iggy+quic://` and token-only credentials, and map `tls=true|false` to `.tls(...)`, delegating to the existing builder methods. Tests will go next to `IggyTcpClientBuilderTest`. One question: the Rust and Node parsers also accept `tls_domain`, `tls_ca_file`, `nodelay`, `reconnection_*` and `heartbeat_interval`. Should Java reject anything other than `tls` for now, or map `tls_ca_file` to the existing `tlsCertificate(...)` setter? I'd lean towards rejecting unknown options with a clear error, so a string that works in Rust never silently behaves differently in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
