krishvishal opened a new pull request, #4534:
URL: https://github.com/apache/iggy/pull/4534

     Relates to #4508
   
     ## Rationale
   
   Two gateway answers break common Kafka clients. #4398 made DescribeConfigs 
report `cleanup.policy=delete` for every topic. Kafka Connect refuses an 
internal topic with any policy other than `compact`, even a topic that an 
operator created by hand. When the entry is missing, Connect logs one INFO line 
and starts (`TopicAdmin.verifyTopicCleanupPolicyOnlyCompact`). When the caller 
gives no partition count or replication factor, KafkaJS `createTopics()` sends 
`-1` for both at v3. The gateway refused `-1` below v4.
   
   Connect still cannot create its own internal topics through the gateway, 
because CreateTopics refuses any topic configuration and any replication factor 
above 1. The rest of #4508 covers that.
   
     ## What changed?
   
   DescribeConfigs reported a fixed `cleanup.policy=delete`, and CreateTopics 
answered `INVALID_PARTITIONS` (37) or `INVALID_REPLICATION_FACTOR` (38) to `-1` 
below v4. DescribeConfigs now leaves out `cleanup.policy`, also for a request 
that names it, until the gateway stores a policy per topic. CreateTopics reads 
`-1` partitions or replication factor as the broker default at every version, 
as Kafka's controller does (`ReplicationControlManager.createTopic`). 
`CONFIGS.md` also drops a wrong claim that clients fall back from 
IncrementalAlterConfigs (44) to AlterConfigs (33).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to