SunilKumarPradhan commented on PR #4490: URL: https://github.com/apache/iggy/pull/4490#issuecomment-6233738114
> I do not think that we need the mock test where you are spinning up a fake server since what you are testing is the rust sdk, not the python sdk. `test_role_and_status_are_comparable_and_hashable` is also not needed. Not the python sdk's responsibility. > > Let's remove both Makes sense, noticed that too and already fixed it in my recent commit. The mock HTTP server test and the role/status enum test are gone now, along with the now-unused serve_cluster_metadata helper and the related imports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
