This is an automated email from the ASF dual-hosted git repository.
hubcio pushed a commit to branch chore/team-review-pr-guidance
in repository https://gitbox.apache.org/repos/asf/iggy.git
The following commit(s) were added to refs/heads/chore/team-review-pr-guidance
by this push:
new fba564261 ci(rust): keep coverage merge failures from failing test
shards
fba564261 is described below
commit fba5642614860186449a15a720d5d99737ae9b80
Author: Hubert Gruszecki <[email protected]>
AuthorDate: Wed Oct 21 13:22:14 2026 +0200
ci(rust): keep coverage merge failures from failing test shards
A green Rust test shard still failed when one .profraw file was
truncated. llvm-profdata merge defaults to --failure-mode=any, so
one bad file rejects the whole merge. The truncated file comes from
iggy-connectors, which the integration harness SIGKILLs 5 s after
SIGTERM, sometimes while it writes its profile at exit.
Coverage is advisory, because all Codecov statuses are
informational. Let the report step fail without failing the shard.
The shutdown race itself stays open.
---
.github/workflows/_rust_tests.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.github/workflows/_rust_tests.yml
b/.github/workflows/_rust_tests.yml
index 870c2b0cd..e15e2e8ad 100644
--- a/.github/workflows/_rust_tests.yml
+++ b/.github/workflows/_rust_tests.yml
@@ -56,6 +56,9 @@ jobs:
- name: Generate coverage report
if: always() && !cancelled()
+ # Coverage must not block the PR: llvm-profdata rejects the whole
+ # merge when a single .profraw file is truncated.
+ continue-on-error: true
run: |
if compgen -G 'target/*.profraw' > /dev/null; then
cargo llvm-cov report --codecov --output-path codecov.json