spetz commented on code in PR #4615:
URL: https://github.com/apache/iggy/pull/4615#discussion_r4337736503
##########
core/partitions/src/iggy_partition.rs:
##########
@@ -4079,6 +4098,7 @@ where
fragments: result.fragments,
current_offset: result.commit_offset,
replication,
+ encryptor: self.encryptor.clone(),
Review Comment:
Fixed. `complete_poll` carries the encryptor only when the reply has
fragments (`core/partitions/src/iggy_partition.rs:4100`), so an empty poll no
longer touches the owner shard's `Arc` refcount and takes the plain reply path.
`given_empty_poll_of_encrypted_stream_when_replying_should_not_carry_its_key`
failed on the old code and passes now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
