slbotbm commented on code in PR #4397:
URL: https://github.com/apache/iggy/pull/4397#discussion_r4445125647


##########
foreign/cpp/src/client.cpp:
##########
@@ -280,14 +280,32 @@ TopicDetails IggyBlockingClient::CreateTopic(const 
Identifier &stream,
         }
         if (auto value = options.Durability()) {
             ffi_options.has_durability = true;
-            ffi_options.durability     = std::string(iggy::to_string(*value));
+            switch (*value) {

Review Comment:
   I think it is fine as it is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to