spetz commented on PR #4714: URL: https://github.com/apache/iggy/pull/4714#issuecomment-6607297340
@hubcio Review body items: - The contributing lint block now lints the root `Package.swift` (`foreign/swift/README.md:550`). - The path snippet depends on the checkout root with `.package(path: "../iggy")` and `package: "iggy"`, the same product reference as the remote form (`foreign/swift/README.md:61`). - Swift is in the `foreign/` line of the structure tree (`AGENTS.md:118`). - Confirmed: the repository holds `swiftpm-*-examples-*` caches only, from the job that calls setup-swift directly, and no `sdk` cache at all. setup-swift now only restores, with `actions/cache/restore`, and exposes the key (`.github/actions/utils/setup-swift/action.yml:104`). The Swift test lane saves with `actions/cache/save` after its build (`.github/actions/swift/pre-merge/action.yml:88`), and so does the examples job (`.github/workflows/_test_examples.yml:109`). Only the test lane saves, since the lanes share one key and the e2e lane builds the same debug products. - The whole `.build` directory is cached now (`.github/actions/utils/setup-swift/action.yml:106`). Besides `workspace-state.json`, the old paths missed the build products too: with Swift 6.4, `.build/debug` and `.build/release` are symlinks into `.build/out`, so the cache held only the links. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
