hubcio commented on code in PR #4609:
URL: https://github.com/apache/iggy/pull/4609#discussion_r4471619544
##########
helm/charts/iggy/README.md.gotmpl:
##########
@@ -91,6 +91,13 @@ helm install iggy ./helm/charts/iggy \
--set server.persistence.size=50Gi
```
+With persistence on, the chart uses the `Recreate` strategy. A rolling update
Review Comment:
warning: 0.9.0 writes snapshots and superblocks that 0.9.0-edge.6 cannot
read, so a helm rollback alone cannot restore service. document a consistent
pre-upgrade volume backup and restoration before downgrading.
##########
helm/charts/iggy/Chart.yaml:
##########
@@ -21,7 +21,7 @@ name: iggy
description: A Helm chart for Apache Iggy server and web-ui
type: application
version: 0.7.0
-appVersion: "0.9.0-edge.6"
+appVersion: "0.9.0"
Review Comment:
critical: the default image no longer supports stored `enforce_fsync=true`
topic options, and the chart supplies no migration. provide an upgrade path
that preserves existing durability policies before changing the image.
##########
helm/charts/iggy/README.md.gotmpl:
##########
@@ -91,6 +91,13 @@ helm install iggy ./helm/charts/iggy \
--set server.persistence.size=50Gi
```
+With persistence on, the chart uses the `Recreate` strategy. A rolling update
+starts the replacement server while the outgoing one is still running on the
+same volume, which loses messages. Charts before 0.7.0 used a rolling update
+here, so an existing release moves from `RollingUpdate` to `Recreate` on its
+first upgrade. On Helm 4, run that one upgrade with
Review Comment:
warning: existing `server.env` overrides using relocated `IGGY_SYSTEM_*`
keys prevent 0.9.0 from starting. document required renames, including
`IGGY_SYSTEM_SHARDING_CPU_ALLOCATION` to `IGGY_SHARDING_CPU_ALLOCATION`, and
regenerate the readme.
##########
helm/charts/iggy/templates/_helpers.tpl:
##########
@@ -319,8 +319,11 @@ Secret owns it.
{{- $configVersion := $server.encryption.configVersion | default "auto" }}
{{- if eq $configVersion "auto" }}
{{- $imageTag := $server.image.tag | default .Chart.AppVersion }}
- {{- if and (regexMatch "^v?[0-9]+\\.[0-9]+\\.[0-9]+([+-].*)?$"
$imageTag) (semverCompare "<=0.9.0-edge.7" $imageTag) }}
+ {{- $versioned := regexMatch "^v?[0-9]+\\.[0-9]+\\.[0-9]+([+-].*)?$"
$imageTag }}
+ {{- if and $versioned (semverCompare "<=0.9.0-edge.7" $imageTag) }}
{{- $configVersion = "legacy" }}
+ {{- else if $versioned }}
Review Comment:
warning: a referenced secret containing `encryptionPreviousKeys` now emits
`IGGY_ENCRYPTION_PREVIOUS_KEYS`, which 0.9.0 rejects. gate previous-key
variables by server support and reject inline previous keys on unsupported
releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
