hubcio commented on code in PR #4718:
URL: https://github.com/apache/iggy/pull/4718#discussion_r4469913511
##########
examples/php/README.md:
##########
@@ -34,6 +34,19 @@ php -d
extension="${PHP_IGGY_EXTENSION:-../../foreign/php/target/debug/libiggy_p
php -d
extension="${PHP_IGGY_EXTENSION:-../../foreign/php/target/debug/libiggy_php.so}"
basic/consumer.php
```
+### Message Envelopes
+
+The message envelope pattern wraps each payload in a JSON object with a
+`message_type` and a `payload` string, so one topic can carry several kinds of
+messages. The producer sends `OrderCreated`, `OrderConfirmed` and
+`OrderRejected` messages, and the consumer dispatches on `message_type`. A
+message with an unknown type is logged and skipped.
+
+```bash
+php -d
extension="${PHP_IGGY_EXTENSION:-../../foreign/php/target/debug/libiggy_php.so}"
message-envelope/producer.php
Review Comment:
critical: both documented envelope commands target missing
`message-envelope` scripts because the implementation replaces the `basic`
scripts instead. add the scripts under `examples/php/message-envelope/` and
restore the original basic example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
