mmmmxa opened a new issue, #4748:
URL: https://github.com/apache/iggy/issues/4748

   ## Do not start before #4533 is merged
   
   This issue is valid only after #4533 is merged. It depends on the crate list 
that PR produces: the connectors runtime plus every connector plugin. Work 
started before the merge can use an incomplete list.
   
   ## Problem
   
   The fat `apache/iggy-connect` image bundles many third-party crates. Some of 
them ship their own NOTICE file, for example `parquet`, `arrow-array`, 
`object_store` (`NOTICE.txt`), and `iceberg`, `apache-avro` (`NOTICE`).
   
   The image carries only the repository `NOTICE`, which 
`core/connectors/runtime/Dockerfile` copies to `/usr/share/doc/iggy-connect/`. 
The generated `LICENSE-binary` comes from `about.hbs`. That template prints 
license names, the crates that use each license, and the license text. It does 
not print NOTICE content.
   
   ASF policy requires that the NOTICE content of bundled Apache-2.0 software 
reaches the distribution. The fat image does not do this today.
   
   ## Expected result
   
   The fat image ships the NOTICE content of every bundled crate that has one. 
The content comes from the full crate list, not from the plugins alone.
   
   ## Open questions
   
   - Does the content go into the shipped `NOTICE` file, or into a separate 
file next to it?
   - Does the slim image need the same change for the runtime crates?
   - Which tool collects the NOTICE files: `cargo-about`, or a step in 
`scripts/ci/third-party-licenses.sh`?
   - A PMC member must review the result, because it is legal text.
   
   ## Origin
   
   Raised in the review of #4533 (https://github.com/apache/iggy/pull/4533), 
comment on `core/connectors/runtime/Dockerfile`. The reviewer agreed that this 
can be a follow-up.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to