ignite-1294: added race related comment
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/9e426004 Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/9e426004 Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/9e426004 Branch: refs/heads/ignite-1093-2 Commit: 9e426004f7c38c72f82460f85f11208ea544f25c Parents: 0dab4df Author: Denis Magda <[email protected]> Authored: Mon Aug 31 18:00:21 2015 +0300 Committer: Denis Magda <[email protected]> Committed: Mon Aug 31 18:00:21 2015 +0300 ---------------------------------------------------------------------- .../apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java | 1 + 1 file changed, 1 insertion(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/9e426004/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java b/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java index 0be65a7..2594213 100644 --- a/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java +++ b/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java @@ -507,6 +507,7 @@ public class TcpCommunicationSpi extends IgniteSpiAdapter ses.send(new RecoveryLastReceivedMessage(-1)); } else { + // The code below causes a race condition between shmem and TCP (see IGNITE-1294) boolean reserved = recoveryDesc.tryReserve(msg0.connectCount(), new ConnectClosure(ses, recoveryDesc, rmtNode, msg0, !hasShmemClient, fut));
