wip
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/f704b5fd Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/f704b5fd Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/f704b5fd Branch: refs/heads/ignite-2324 Commit: f704b5fd2e0e9dca0e5959d2d9b7b6d777fa1cbe Parents: b4131bc Author: Pavel Tupitsyn <ptupit...@gridgain.com> Authored: Wed Jan 13 19:21:35 2016 +0300 Committer: Pavel Tupitsyn <ptupit...@gridgain.com> Committed: Wed Jan 13 19:21:35 2016 +0300 ---------------------------------------------------------------------- .../Apache.Ignite.Core.ruleset | 125 ++----------------- .../Compute/ComputeJobAdapter.cs | 2 +- .../Apache.Ignite.Core/Impl/Common/Future.cs | 1 + 3 files changed, 12 insertions(+), 116 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/f704b5fd/modules/platforms/dotnet/Apache.Ignite.Core/Apache.Ignite.Core.ruleset ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Apache.Ignite.Core.ruleset b/modules/platforms/dotnet/Apache.Ignite.Core/Apache.Ignite.Core.ruleset index ba6c8e6..35f156c 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Apache.Ignite.Core.ruleset +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Apache.Ignite.Core.ruleset @@ -2,122 +2,17 @@ <RuleSet Name="Rules for Apache.Ignite.Core" Description="Code analysis rules for Apache.Ignite.Core.csproj." ToolsVersion="14.0"> <IncludeAll Action="Warning" /> <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed"> + <Rule Id="CA1004" Action="None" /> + <Rule Id="CA1005" Action="None" /> + <Rule Id="CA1006" Action="None" /> + <Rule Id="CA1020" Action="None" /> + <Rule Id="CA1021" Action="None" /> + <Rule Id="CA1024" Action="None" /> + <Rule Id="CA1305" Action="None" /> + <Rule Id="CA1307" Action="None" /> <Rule Id="CA1502" Action="None" /> <Rule Id="CA1506" Action="None" /> - </Rules> - <Rules AnalyzerId="SonarLint.CSharp" RuleNamespace="SonarLint.CSharp"> - <Rule Id="S1066" Action="None" /> - <Rule Id="S1067" Action="None" /> - <Rule Id="S107" Action="None" /> - <Rule Id="S108" Action="None" /> - <Rule Id="S1116" Action="None" /> - <Rule Id="S1117" Action="None" /> - <Rule Id="S1118" Action="None" /> - <Rule Id="S1121" Action="None" /> - <Rule Id="S1125" Action="None" /> - <Rule Id="S1134" Action="None" /> - <Rule Id="S1135" Action="None" /> - <Rule Id="S1145" Action="None" /> - <Rule Id="S1155" Action="None" /> - <Rule Id="S1172" Action="None" /> - <Rule Id="S1186" Action="None" /> - <Rule Id="S122" Action="None" /> - <Rule Id="S1226" Action="None" /> - <Rule Id="S1244" Action="None" /> - <Rule Id="S125" Action="None" /> - <Rule Id="S127" Action="None" /> - <Rule Id="S131" Action="None" /> - <Rule Id="S1313" Action="None" /> - <Rule Id="S1449" Action="None" /> - <Rule Id="S1479" Action="None" /> - <Rule Id="S1481" Action="None" /> - <Rule Id="S1541" Action="None" /> - <Rule Id="S1643" Action="None" /> - <Rule Id="S1656" Action="None" /> - <Rule Id="S1659" Action="None" /> - <Rule Id="S1697" Action="None" /> - <Rule Id="S1699" Action="None" /> - <Rule Id="S1764" Action="None" /> - <Rule Id="S1848" Action="None" /> - <Rule Id="S1854" Action="None" /> - <Rule Id="S1862" Action="None" /> - <Rule Id="S1871" Action="None" /> - <Rule Id="S1905" Action="None" /> - <Rule Id="S1939" Action="None" /> - <Rule Id="S1940" Action="None" /> - <Rule Id="S1994" Action="None" /> - <Rule Id="S2123" Action="None" /> - <Rule Id="S2219" Action="None" /> - <Rule Id="S2223" Action="None" /> - <Rule Id="S2225" Action="None" /> - <Rule Id="S2228" Action="None" /> - <Rule Id="S2234" Action="None" /> - <Rule Id="S2275" Action="None" /> - <Rule Id="S2290" Action="None" /> - <Rule Id="S2291" Action="None" /> - <Rule Id="S2292" Action="None" /> - <Rule Id="S2306" Action="None" /> - <Rule Id="S2326" Action="None" /> - <Rule Id="S2328" Action="None" /> - <Rule Id="S2333" Action="None" /> - <Rule Id="S2344" Action="None" /> - <Rule Id="S2345" Action="None" /> - <Rule Id="S2346" Action="None" /> - <Rule Id="S2360" Action="None" /> - <Rule Id="S2368" Action="None" /> - <Rule Id="S2372" Action="None" /> - <Rule Id="S2376" Action="None" /> - <Rule Id="S2387" Action="None" /> - <Rule Id="S2437" Action="None" /> - <Rule Id="S2486" Action="None" /> - <Rule Id="S2551" Action="None" /> - <Rule Id="S2674" Action="None" /> - <Rule Id="S2681" Action="None" /> - <Rule Id="S2692" Action="None" /> - <Rule Id="S2696" Action="None" /> - <Rule Id="S2737" Action="None" /> - <Rule Id="S2743" Action="None" /> - <Rule Id="S2757" Action="None" /> - <Rule Id="S2758" Action="None" /> - <Rule Id="S2761" Action="None" /> - <Rule Id="S2930" Action="None" /> - <Rule Id="S2931" Action="None" /> - <Rule Id="S2933" Action="None" /> - <Rule Id="S2934" Action="None" /> - <Rule Id="S2952" Action="None" /> - <Rule Id="S2953" Action="None" /> - <Rule Id="S2955" Action="None" /> - <Rule Id="S2971" Action="None" /> - <Rule Id="S2995" Action="None" /> - <Rule Id="S2996" Action="None" /> - <Rule Id="S2997" Action="None" /> - <Rule Id="S3005" Action="None" /> - <Rule Id="S3052" Action="None" /> - <Rule Id="S3168" Action="None" /> - <Rule Id="S3169" Action="None" /> - <Rule Id="S3172" Action="None" /> - <Rule Id="S3215" Action="None" /> - <Rule Id="S3216" Action="None" /> - <Rule Id="S3217" Action="None" /> - <Rule Id="S3218" Action="None" /> - <Rule Id="S3220" Action="None" /> - <Rule Id="S3234" Action="None" /> - <Rule Id="S3235" Action="None" /> - <Rule Id="S3236" Action="None" /> - <Rule Id="S3237" Action="None" /> - <Rule Id="S3240" Action="None" /> - <Rule Id="S3244" Action="None" /> - <Rule Id="S3246" Action="None" /> - <Rule Id="S3249" Action="None" /> - <Rule Id="S3253" Action="None" /> - <Rule Id="S3254" Action="None" /> - <Rule Id="S3262" Action="None" /> - <Rule Id="S3263" Action="None" /> - <Rule Id="S3376" Action="None" /> - <Rule Id="S3397" Action="None" /> - <Rule Id="S3427" Action="None" /> - <Rule Id="S818" Action="None" /> - <Rule Id="S907" Action="None" /> - <Rule Id="S927" Action="None" /> + <Rule Id="CA1709" Action="None" /> + <Rule Id="CA1720" Action="None" /> </Rules> </RuleSet> \ No newline at end of file http://git-wip-us.apache.org/repos/asf/ignite/blob/f704b5fd/modules/platforms/dotnet/Apache.Ignite.Core/Compute/ComputeJobAdapter.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Compute/ComputeJobAdapter.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Compute/ComputeJobAdapter.cs index 2a0ed4e..c53279e 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Compute/ComputeJobAdapter.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Compute/ComputeJobAdapter.cs @@ -88,7 +88,7 @@ namespace Apache.Ignite.Core.Compute public TArg GetArgument<TArg>(int idx) { if (_args == null || idx < 0 || idx >= _args.Length) - throw new IndexOutOfRangeException("Invalid argument index: " + idx); + throw new ArgumentOutOfRangeException("Invalid argument index: " + idx); return (TArg)_args[idx]; } http://git-wip-us.apache.org/repos/asf/ignite/blob/f704b5fd/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs index 3e99040..6815df7 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Common/Future.cs @@ -70,6 +70,7 @@ namespace Apache.Ignite.Core.Impl.Common /// <summary> /// Gets the task. /// </summary> + [SuppressMessage("Microsoft.Naming", "CA1721:PropertyNamesShouldNotMatchGetMethods")] public Task<T> Task { get { return _taskCompletionSource.Task; }