Minors.
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/f32f1d8d Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/f32f1d8d Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/f32f1d8d Branch: refs/heads/ignite-2523-1-resp-dht Commit: f32f1d8debcb68efff5c87c49c6af9c907b4346d Parents: 4ef6868 Author: vozerov-gridgain <[email protected]> Authored: Thu Apr 28 16:40:55 2016 +0300 Committer: vozerov-gridgain <[email protected]> Committed: Thu Apr 28 16:40:55 2016 +0300 ---------------------------------------------------------------------- .../dht/atomic/GridDhtAtomicAbstractUpdateFuture.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/f32f1d8d/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicAbstractUpdateFuture.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicAbstractUpdateFuture.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicAbstractUpdateFuture.java index 4e166b1..e930d1a 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicAbstractUpdateFuture.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicAbstractUpdateFuture.java @@ -133,6 +133,7 @@ public abstract class GridDhtAtomicAbstractUpdateFuture extends GridFutureAdapte * @param prevVal Previous value. * @param updateCntr Partition update counter. */ + @SuppressWarnings("ForLoopReplaceableByForEach") public void addWriteEntry(GridDhtCacheEntry entry, @Nullable CacheObject val, EntryProcessor<Object, Object, Object> entryProcessor, @@ -142,15 +143,16 @@ public abstract class GridDhtAtomicAbstractUpdateFuture extends GridFutureAdapte boolean addPrevVal, @Nullable CacheObject prevVal, long updateCntr) { - Collection<ClusterNode> dhtNodes = cctx.dht().topology().nodes(entry.partition(), updateReq.topologyVersion()); + List<ClusterNode> dhtNodes = cctx.dht().topology().nodes(entry.partition(), updateReq.topologyVersion()); if (log.isDebugEnabled()) log.debug("Mapping entry to DHT nodes [nodes=" + U.nodeIds(dhtNodes) + ", entry=" + entry + ']'); addKey(entry.key()); - // TODO: Avoid iteration, we usually will have only one node here. - for (ClusterNode node : dhtNodes) { + for (int i = 0; i < dhtNodes.size(); i++) { + ClusterNode node = dhtNodes.get(i); + UUID nodeId = node.id(); if (!nodeId.equals(cctx.localNodeId())) {
