Repository: ignite Updated Branches: refs/heads/master f9c96de57 -> cee5dd84a
.NET: Fix code analysis warnings Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/cee5dd84 Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/cee5dd84 Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/cee5dd84 Branch: refs/heads/master Commit: cee5dd84a23cf0456e30149767a7cf5ba70841f6 Parents: f9c96de Author: Pavel Tupitsyn <[email protected]> Authored: Mon May 29 20:01:46 2017 +0300 Committer: Pavel Tupitsyn <[email protected]> Committed: Mon May 29 20:01:46 2017 +0300 ---------------------------------------------------------------------- .../dotnet/Apache.Ignite.Core/Cache/Configuration/QueryEntity.cs | 4 ++-- modules/platforms/dotnet/Apache.Ignite.FxCop | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/cee5dd84/modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/QueryEntity.cs ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/QueryEntity.cs b/modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/QueryEntity.cs index 58e5af9..ff61394 100644 --- a/modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/QueryEntity.cs +++ b/modules/platforms/dotnet/Apache.Ignite.Core/Cache/Configuration/QueryEntity.cs @@ -34,7 +34,7 @@ namespace Apache.Ignite.Core.Cache.Configuration /// Query entity is a description of cache entry (composed of key and value) /// in a way of how it must be indexed and can be queried. /// </summary> - public class QueryEntity : IQueryEntityInternal + public sealed class QueryEntity : IQueryEntityInternal { /** */ private Type _keyType; @@ -216,7 +216,7 @@ namespace Apache.Ignite.Core.Cache.Configuration // PERF: No ToDictionary. if (_aliasMap == null) { - _aliasMap = new Dictionary<string, string>(Aliases.Count, StringComparer.InvariantCulture); + _aliasMap = new Dictionary<string, string>(Aliases.Count, StringComparer.Ordinal); foreach (var alias in Aliases) { http://git-wip-us.apache.org/repos/asf/ignite/blob/cee5dd84/modules/platforms/dotnet/Apache.Ignite.FxCop ---------------------------------------------------------------------- diff --git a/modules/platforms/dotnet/Apache.Ignite.FxCop b/modules/platforms/dotnet/Apache.Ignite.FxCop index 109f59f..3653fa0 100644 --- a/modules/platforms/dotnet/Apache.Ignite.FxCop +++ b/modules/platforms/dotnet/Apache.Ignite.FxCop @@ -21,9 +21,9 @@ <IgnoreGeneratedCode>False</IgnoreGeneratedCode> </ProjectOptions> <Targets> + <Target Name="$(ProjectDir)/Apache.Ignite.AspNet/bin/Debug/Apache.Ignite.AspNet.dll" Analyze="True" AnalyzeAllChildren="True" /> <Target Name="$(ProjectDir)/Apache.Ignite.Core/bin/Debug/Apache.Ignite.Core.dll" Analyze="True" AnalyzeAllChildren="True" /> <Target Name="$(ProjectDir)/Apache.Ignite.Linq/bin/Debug/Apache.Ignite.Linq.dll" Analyze="True" AnalyzeAllChildren="True" /> - <Target Name="$(ProjectDir)/Apache.Ignite.AspNet/bin/Debug/Apache.Ignite.AspNet.dll" Analyze="True" AnalyzeAllChildren="True" /> <Target Name="$(ProjectDir)/Apache.Ignite.NLog/bin/Debug/Apache.Ignite.NLog.dll" Analyze="True" AnalyzeAllChildren="True" /> </Targets> <Rules> @@ -33,7 +33,6 @@ <Rule Name="AssembliesShouldHaveValidStrongNames" Enabled="True" /> <Rule Name="AvoidEmptyInterfaces" Enabled="True" /> <Rule Name="CollectionsShouldImplementGenericInterface" Enabled="True" /> - <Rule Name="ConsiderPassingBaseTypesAsParameters" Enabled="True" /> <Rule Name="DeclareEventHandlersCorrectly" Enabled="True" /> <Rule Name="DeclareTypesInNamespaces" Enabled="True" /> <Rule Name="DefineAccessorsForAttributeArguments" Enabled="True" />
