[ignite-teamcity-bot] branch master updated: Scheduled jobs exceptions are catched and logged.

[dpavlov]

This is an automated email from the ASF dual-hosted git repository.

dpavlov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite-teamcity-bot.git


The following commit(s) were added to refs/heads/master by this push:
     new 9e30b53  Scheduled jobs exceptions are catched and logged.
9e30b53 is described below

commit 9e30b5319bb2f1c0e39936ce82fe8fc80437f9d1
Author: Dmitriy Pavlov <dpav...@apache.org>
AuthorDate: Wed Sep 12 15:54:11 2018 +0300

    Scheduled jobs exceptions are catched and logged.
---
 .../org/apache/ignite/ci/issue/IssueDetector.java     | 19 ++++++++++++++++++-
 .../java/org/apache/ignite/ci/jobs/CheckQueueJob.java | 14 +++++++++++++-
 2 files changed, 31 insertions(+), 2 deletions(-)

diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
index 4c8543c..1db7f49 100644
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
@@ -348,7 +348,7 @@ public class IssueDetector {
 
                 executorService = Executors.newScheduledThreadPool(1);
 
-                executorService.scheduleAtFixedRate(this::checkFailures, 0, 
15, TimeUnit.MINUTES);
+                executorService.scheduleWithFixedDelay(this::checkFailures, 0, 
15, TimeUnit.MINUTES);
 
                 if 
(Boolean.valueOf(System.getProperty(CheckQueueJob.AUTO_TRIGGERING_BUILD_DISABLED)))
                     logger.info("Automatic build triggering was disabled.");
@@ -367,7 +367,24 @@ public class IssueDetector {
         // SchedulerFuture<?> future = 
ignite.scheduler().scheduleLocal(this::checkFailures, "? * * * * *");
     }
 
+    /**
+     *
+     */
     private void checkFailures() {
+        try {
+            checkFailuresEx();
+        }
+        catch (Exception e) {
+            e.printStackTrace();
+
+            logger.error("Failure periodic check failed: " + e.getMessage(), 
e);
+        }
+    }
+
+    /**
+     *
+     */
+    private void checkFailuresEx() {
         int buildsToQry = 
EventTemplates.templates.stream().mapToInt(EventTemplate::cntEvents).max().getAsInt();
 
         
GetTrackedBranchTestResults.getTrackedBranchTestFailures(FullQueryParams.DEFAULT_BRANCH_NAME,
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jobs/CheckQueueJob.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jobs/CheckQueueJob.java
index 7eb7e7a..2de41ba 100644
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jobs/CheckQueueJob.java
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/jobs/CheckQueueJob.java
@@ -70,6 +70,18 @@ public class CheckQueueJob implements Runnable {
 
     /** {@inheritDoc} */
     @Override public void run() {
+        try {
+            runEx();
+        }
+        catch (Exception e) {
+            e.printStackTrace();
+
+            logger.error("Check Queue periodic check failed: " + 
e.getMessage(), e);
+        }
+    }
+
+    /**   */
+    public void runEx() {
         String branch = FullQueryParams.DEFAULT_BRANCH_NAME;
 
         final BranchTracked tracked = 
HelperConfig.getTrackedBranches().getBranchMandatory(branch);
@@ -207,7 +219,7 @@ public class CheckQueueJob implements Runnable {
                 continue;
             }
 
-            logger.debug("Checking queue for server {}.", srv);
+            logger.info("Checking queue for server {}.", srv);
 
             chainsBySrv.computeIfAbsent(srv, v -> new 
ArrayList<>()).add(chain);
         }