IGNITE-7993 Striped pool cannot be disabled (updated javadoc) - Fixes #5596.
Signed-off-by: Ilya Kasnacheev <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/57ccf9b7 Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/57ccf9b7 Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/57ccf9b7 Branch: refs/heads/ignite-10189 Commit: 57ccf9b79e01404e18d25c202bfab4462b01cd9e Parents: 3fb68f7 Author: Roman Guseinov <[email protected]> Authored: Fri Dec 7 13:21:41 2018 +0300 Committer: Ilya Kasnacheev <[email protected]> Committed: Fri Dec 7 13:21:41 2018 +0300 ---------------------------------------------------------------------- .../ignite/configuration/IgniteConfiguration.java | 12 ++---------- .../visor/node/VisorExecutorServiceConfiguration.java | 4 +--- 2 files changed, 3 insertions(+), 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/57ccf9b7/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java index 6ece0e4..9498c5b 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java @@ -839,13 +839,9 @@ public class IgniteConfiguration { * Returns striped pool size that should be used for cache requests * processing. * <p> - * If set to non-positive value then requests get processed in system pool. - * <p> * Striped pool is better for typical cache operations. * - * @return Positive value if striped pool should be initialized - * with configured number of threads (stripes) and used for requests processing - * or non-positive value to process requests in system pool. + * @return The number of threads (stripes) to be used for requests processing. * * @see #getPublicThreadPoolSize() * @see #getSystemThreadPoolSize() @@ -858,13 +854,9 @@ public class IgniteConfiguration { * Sets striped pool size that should be used for cache requests * processing. * <p> - * If set to non-positive value then requests get processed in system pool. - * <p> * Striped pool is better for typical cache operations. * - * @param stripedPoolSize Positive value if striped pool should be initialized - * with passed in number of threads (stripes) and used for requests processing - * or non-positive value to process requests in system pool. + * @param stripedPoolSize The number of threads (stripes) to be used for requests processing. * @return {@code this} for chaining. * * @see #getPublicThreadPoolSize() http://git-wip-us.apache.org/repos/asf/ignite/blob/57ccf9b7/modules/core/src/main/java/org/apache/ignite/internal/visor/node/VisorExecutorServiceConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/visor/node/VisorExecutorServiceConfiguration.java b/modules/core/src/main/java/org/apache/ignite/internal/visor/node/VisorExecutorServiceConfiguration.java index bf2572b..b77c979 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/visor/node/VisorExecutorServiceConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/visor/node/VisorExecutorServiceConfiguration.java @@ -191,9 +191,7 @@ public class VisorExecutorServiceConfiguration extends VisorDataTransferObject { } /** - * @return Positive value if striped pool should be initialized - * with configured number of threads (stripes) and used for requests processing - * or non-positive value to process requests in system pool. + * @return The number of threads (stripes) to be used for requests processing. */ public int getStripedPoolSize() { return stripedPoolSize;
