IGNITE-10709 New inspections introduced in 2018+ IntelliJ IDEA version were disabled on TC configuration, unused Suppress removal. - Fixes #5680.
Signed-off-by: Dmitriy Pavlov <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/ignite/repo Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/ad9d5610 Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/ad9d5610 Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/ad9d5610 Branch: refs/heads/ignite-10639 Commit: ad9d5610e9f2f72a42d50630949293f3120bebc6 Parents: c48f3bc Author: Maxim Muzafarov <[email protected]> Authored: Tue Dec 18 19:21:40 2018 +0300 Committer: Dmitriy Pavlov <[email protected]> Committed: Tue Dec 18 19:23:56 2018 +0300 ---------------------------------------------------------------------- idea/ignite_inspections_teamcity.xml | 13 +++++++++++++ .../org/apache/ignite/IgniteJdbcThinDataSource.java | 1 - .../java/org/apache/ignite/cache/CacheManager.java | 1 - .../apache/ignite/cache/affinity/AffinityKey.java | 1 - .../cache/eviction/fifo/FifoEvictionPolicy.java | 1 - .../cache/eviction/lru/LruEvictionPolicy.java | 1 - .../cache/eviction/sorted/SortedEvictionPolicy.java | 4 ---- .../apache/ignite/compute/ComputeJobAdapter.java | 1 - .../ignite/configuration/CacheConfiguration.java | 4 ---- .../java/org/apache/ignite/events/CacheEvent.java | 1 - .../local/LocalIgfsSecondaryFileSystem.java | 1 - .../apache/ignite/internal/AsyncSupportAdapter.java | 2 -- .../apache/ignite/internal/GridJobContextImpl.java | 1 - .../ignite/internal/GridKernalContextImpl.java | 2 -- .../apache/ignite/internal/GridTaskSessionImpl.java | 3 --- .../apache/ignite/internal/IgniteComponentType.java | 2 -- .../apache/ignite/internal/IgniteComputeImpl.java | 3 --- .../apache/ignite/internal/IgniteEventsImpl.java | 1 - .../org/apache/ignite/internal/IgniteKernal.java | 5 ----- .../apache/ignite/internal/IgniteServicesImpl.java | 1 - .../java/org/apache/ignite/internal/IgnitionEx.java | 1 - .../ignite/internal/binary/BinaryEnumCache.java | 1 - .../internal/binary/BinaryEnumObjectImpl.java | 1 - .../ignite/internal/binary/BinaryFieldImpl.java | 1 - .../ignite/internal/binary/BinaryObjectExImpl.java | 1 - .../ignite/internal/binary/BinaryObjectImpl.java | 7 ------- .../internal/binary/BinaryObjectOffheapImpl.java | 6 ------ .../ignite/internal/binary/BinaryReaderExImpl.java | 3 --- .../ignite/internal/binary/BinaryReaderHandles.java | 1 - .../ignite/internal/binary/BinaryTreeMap.java | 1 - .../apache/ignite/internal/binary/BinaryUtils.java | 3 --- .../ignite/internal/binary/BinaryWriterExImpl.java | 3 --- .../ignite/internal/binary/BinaryWriterHandles.java | 1 - .../internal/binary/GridBinaryMarshaller.java | 3 --- .../binary/builder/BinaryObjectBuilderImpl.java | 1 - .../internal/client/impl/GridClientDataImpl.java | 1 - .../internal/client/impl/GridClientNodeImpl.java | 1 - .../marshaller/jdk/GridClientJdkMarshaller.java | 1 - .../ignite/internal/client/thin/ClientBinary.java | 1 - .../ignite/internal/client/thin/ClientUtils.java | 1 - .../ignite/internal/client/thin/TcpClientCache.java | 1 - .../internal/client/util/GridConcurrentHashSet.java | 2 -- .../internal/direct/state/DirectMessageState.java | 2 -- .../stream/v1/DirectByteBufferStreamImplV1.java | 6 ------ .../stream/v2/DirectByteBufferStreamImplV2.java | 7 ------- .../internal/igfs/common/IgfsControlResponse.java | 1 - .../apache/ignite/internal/jdbc/JdbcResultSet.java | 1 - .../internal/jdbc/thin/JdbcThinConnection.java | 2 -- .../jdbc/thin/JdbcThinDatabaseMetadata.java | 1 - .../jdbc/thin/JdbcThinParameterMetadata.java | 1 - .../jdbc/thin/JdbcThinPreparedStatement.java | 1 - .../internal/jdbc/thin/JdbcThinResultSet.java | 2 -- .../internal/jdbc/thin/JdbcThinStatement.java | 1 - .../ignite/internal/jdbc2/JdbcConnection.java | 1 - .../ignite/internal/jdbc2/JdbcDatabaseMetadata.java | 1 - .../apache/ignite/internal/jdbc2/JdbcResultSet.java | 2 -- .../internal/jdbc2/JdbcResultSetMetadata.java | 1 - .../apache/ignite/internal/jdbc2/JdbcStatement.java | 1 - .../managers/communication/GridIoManager.java | 16 +++------------- .../managers/deployment/GridDeployment.java | 3 --- .../deployment/GridDeploymentLocalStore.java | 1 - .../eventstorage/GridEventStorageManager.java | 4 ---- .../marshaller/optimized/OptimizedMarshaller.java | 2 -- .../optimized/OptimizedObjectInputStream.java | 4 ---- .../processors/affinity/GridAffinityProcessor.java | 1 - .../IgniteAuthenticationProcessor.java | 2 -- .../internal/processors/cache/CacheEntryImpl.java | 1 - .../internal/processors/cache/CacheEntryImpl0.java | 1 - .../processors/cache/CacheEvictableEntryImpl.java | 2 -- .../internal/processors/cache/CacheInvokeEntry.java | 1 - .../processors/cache/CacheInvokeResult.java | 1 - .../internal/processors/cache/CacheLazyEntry.java | 2 -- .../internal/processors/cache/CacheObjectImpl.java | 1 - .../internal/processors/cache/CacheObjectUtils.java | 1 - .../cache/CachePartialUpdateCheckedException.java | 1 - .../internal/processors/cache/GridCacheAdapter.java | 7 +------ .../internal/processors/cache/GridCacheContext.java | 4 ---- .../processors/cache/GridCacheEvictionManager.java | 1 - .../processors/cache/GridCacheIoManager.java | 4 ---- .../processors/cache/GridCacheMapEntry.java | 13 ++----------- .../processors/cache/GridCacheMvccManager.java | 6 ------ .../processors/cache/GridCacheProcessor.java | 6 ------ .../processors/cache/GridCacheProxyImpl.java | 2 -- .../internal/processors/cache/GridCacheReturn.java | 3 --- .../processors/cache/GridCacheUtilityKey.java | 1 - .../internal/processors/cache/GridCacheUtils.java | 6 ------ .../cache/IgniteCacheOffheapManagerImpl.java | 2 -- .../internal/processors/cache/IgniteCacheProxy.java | 2 -- .../processors/cache/IgniteCacheProxyImpl.java | 3 --- .../processors/cache/KeyCacheObjectImpl.java | 1 - .../cache/affinity/GridCacheAffinityProxy.java | 1 - .../binary/CacheObjectBinaryProcessorImpl.java | 2 -- .../processors/cache/binary/IgniteBinaryImpl.java | 1 - .../datastructures/CacheDataStructuresManager.java | 4 ---- .../dht/CacheDistributedGetFutureAdapter.java | 1 - .../cache/distributed/dht/GridDhtCacheAdapter.java | 2 +- .../cache/distributed/dht/GridDhtCacheEntry.java | 4 +--- .../cache/distributed/dht/GridDhtLockFuture.java | 2 -- .../dht/GridDhtTxAbstractEnlistFuture.java | 2 -- .../distributed/dht/GridDhtTxFinishFuture.java | 3 --- .../cache/distributed/dht/GridDhtTxLocal.java | 2 -- .../distributed/dht/GridDhtTxPrepareFuture.java | 1 - .../dht/NearTxQueryEnlistResultHandler.java | 1 - .../cache/distributed/dht/NearTxResultHandler.java | 1 - .../distributed/dht/atomic/GridDhtAtomicCache.java | 3 --- .../dht/atomic/GridNearAtomicFullUpdateRequest.java | 2 -- .../atomic/GridNearAtomicSingleUpdateFuture.java | 1 - .../dht/atomic/GridNearAtomicUpdateFuture.java | 5 ----- .../dht/colocated/GridDhtColocatedCache.java | 1 - .../dht/preloader/GridDhtForceKeysFuture.java | 2 -- .../dht/preloader/GridDhtPartitionSupplier.java | 1 - .../preloader/GridDhtPartitionsSingleMessage.java | 1 - .../dht/topology/GridClientPartitionTopology.java | 2 -- .../dht/topology/GridDhtPartitionTopologyImpl.java | 2 -- .../cache/distributed/near/GridNearAtomicCache.java | 4 ---- .../cache/distributed/near/GridNearGetFuture.java | 1 - .../cache/distributed/near/GridNearLockFuture.java | 1 - .../distributed/near/GridNearTxFinishFuture.java | 2 -- .../cache/distributed/near/GridNearTxLocal.java | 3 --- .../cache/local/atomic/GridLocalAtomicCache.java | 8 -------- .../processors/cache/mvcc/MvccProcessorImpl.java | 2 -- .../cache/persistence/pagemem/PageMemoryImpl.java | 1 - .../cache/persistence/tree/BPlusTree.java | 16 ---------------- .../cache/persistence/tree/io/PageIO.java | 2 -- .../query/GridCacheDistributedQueryFuture.java | 3 --- .../query/GridCacheDistributedQueryManager.java | 4 ---- .../cache/query/GridCacheQueryAdapter.java | 5 +---- .../cache/query/GridCacheQueryFutureAdapter.java | 3 --- .../cache/query/GridCacheQueryManager.java | 2 +- .../cache/query/GridCacheQueryResponse.java | 1 - .../cache/query/GridCacheQueryResponseEntry.java | 1 - .../continuous/CacheContinuousQueryEventBuffer.java | 1 - .../continuous/CacheContinuousQueryHandler.java | 1 - .../continuous/CacheContinuousQueryHandlerV3.java | 2 -- .../continuous/CacheContinuousQueryManager.java | 2 -- .../cache/store/GridCacheWriteBehindStore.java | 1 - .../cache/transactions/IgniteTxAdapter.java | 2 +- .../cache/transactions/IgniteTxLocalAdapter.java | 1 - .../cache/transactions/IgniteTxManager.java | 7 ------- .../cache/transactions/TxDeadlockDetection.java | 1 - .../version/GridCacheLazyPlainVersionedEntry.java | 1 - .../processors/cluster/ClusterProcessor.java | 1 - .../continuous/GridContinuousMessage.java | 1 - .../continuous/GridContinuousProcessor.java | 3 --- .../processors/continuous/StartRequestData.java | 1 - .../processors/datastreamer/DataStreamerImpl.java | 1 - .../datastructures/DataStructuresProcessor.java | 4 ---- .../GridCacheAtomicReferenceValue.java | 1 - .../datastructures/GridCacheAtomicStampedValue.java | 1 - .../datastructures/GridCacheCountDownLatchImpl.java | 1 - .../processors/igfs/IgfsAbstractOutputStream.java | 1 - .../internal/processors/igfs/IgfsDataManager.java | 1 - .../ignite/internal/processors/igfs/IgfsImpl.java | 4 ---- .../processors/igfs/IgfsInputStreamImpl.java | 1 - .../platform/client/ClientResourceRegistry.java | 1 - .../platform/dotnet/PlatformDotNetCacheStore.java | 1 - .../dotnet/PlatformDotNetConfigurationClosure.java | 1 - .../processors/platform/events/PlatformEvents.java | 10 ++++------ .../processors/platform/utils/PlatformUtils.java | 1 - .../processors/plugin/CachePluginManager.java | 3 +-- .../processors/plugin/IgnitePluginProcessor.java | 2 -- .../query/GridQueryCacheObjectsIterator.java | 1 - .../processors/query/GridQueryProcessor.java | 1 - .../processors/query/QueryKeyValueIterator.java | 1 - .../processors/query/QueryTypeDescriptorImpl.java | 1 - .../query/property/QueryBinaryProperty.java | 1 - .../client/message/GridClientTaskResultBean.java | 1 - .../processors/service/GridServiceProcessor.java | 6 ------ .../processors/service/GridServiceProxy.java | 1 - .../processors/service/ServiceContextImpl.java | 1 - .../processors/service/ServiceDescriptorImpl.java | 1 - .../internal/processors/task/GridTaskProcessor.java | 3 --- .../internal/processors/task/GridTaskWorker.java | 3 --- .../org/apache/ignite/internal/util/GridArrays.java | 1 - .../internal/util/GridBoundedLinkedHashMap.java | 1 - .../internal/util/GridBoundedLinkedHashSet.java | 1 - .../internal/util/GridConcurrentSkipListSet.java | 2 +- .../apache/ignite/internal/util/GridLeanMap.java | 2 +- .../apache/ignite/internal/util/GridLeanSet.java | 1 - .../apache/ignite/internal/util/GridListSet.java | 3 --- .../apache/ignite/internal/util/GridSetWrapper.java | 2 -- .../apache/ignite/internal/util/IgniteUtils.java | 12 ------------ .../util/StripedCompositeReadWriteLock.java | 1 - .../internal/util/future/GridCompoundFuture.java | 3 --- .../internal/util/future/GridFinishedFuture.java | 2 -- .../internal/util/future/GridFutureAdapter.java | 2 -- .../internal/util/future/IgniteFutureImpl.java | 1 - .../apache/ignite/internal/util/lang/GridFunc.java | 11 ----------- .../util/lang/GridMetadataAwareAdapter.java | 7 ------- .../apache/ignite/internal/util/lang/GridTuple.java | 1 - .../ignite/internal/util/lang/GridTuple3.java | 1 - .../ignite/internal/util/lang/GridTuple4.java | 1 - .../ignite/internal/util/lang/GridTuple5.java | 1 - .../ignite/internal/util/lang/GridTuple6.java | 1 - .../util/lang/gridfunc/PredicateMapView.java | 4 ---- .../util/lang/gridfunc/TransformMapView.java | 4 ---- .../util/lang/gridfunc/TransformMapView2.java | 4 ---- .../ignite/internal/util/nio/GridNioServer.java | 5 ----- .../org/apache/ignite/internal/util/typedef/X.java | 3 --- .../java/org/apache/ignite/lang/IgniteBiTuple.java | 1 - .../org/apache/ignite/logger/java/JavaLogger.java | 1 - .../apache/ignite/marshaller/jdk/JdkMarshaller.java | 1 - .../apache/ignite/spi/discovery/tcp/ClientImpl.java | 1 - .../apache/ignite/spi/discovery/tcp/ServerImpl.java | 1 - .../ignite/spi/discovery/tcp/TcpDiscoverySpi.java | 2 -- .../discovery/tcp/internal/TcpDiscoveryNode.java | 1 - .../multicast/TcpDiscoveryMulticastIpFinder.java | 1 - .../java/org/jsr166/ConcurrentLinkedHashMap.java | 12 +----------- .../java/org/apache/ignite/GridTestIoUtils.java | 3 --- .../java/org/apache/ignite/GridTestJobContext.java | 1 - .../java/org/apache/ignite/GridTestTaskSession.java | 1 - .../RendezvousAffinityFunctionSimpleBenchmark.java | 1 - .../ignite/internal/ClusterGroupSelfTest.java | 1 - ...ridEventStorageRuntimeConfigurationSelfTest.java | 1 - .../GridMultipleVersionsDeploymentSelfTest.java | 2 -- .../org/apache/ignite/internal/GridSelfTest.java | 1 - .../IgniteClientReconnectApiExceptionTest.java | 2 -- .../IgniteExplicitImplicitDeploymentSelfTest.java | 4 ---- .../binary/BinaryObjectTypeCompatibilityTest.java | 1 - ...rectByteBufferStreamImplV2ByteOrderSelfTest.java | 1 - .../GridAffinityProcessorAbstractSelfTest.java | 1 - .../cache/CacheConcurrentReadThroughTest.java | 1 - .../processors/cache/CacheMetricsManageTest.java | 1 - .../cache/GridCacheAbstractFullApiSelfTest.java | 1 - .../cache/GridCacheAbstractMetricsSelfTest.java | 1 - .../GridCacheConcurrentTxMultiNodeLoadTest.java | 2 +- .../cache/GridCacheDeploymentSelfTest.java | 2 -- .../cache/GridCacheInterceptorAbstractSelfTest.java | 6 ------ .../processors/cache/GridCacheMvccSelfTest.java | 1 - .../cache/GridCachePutAllFailoverSelfTest.java | 1 - .../cache/IgniteCacheEntryListenerAbstractTest.java | 1 - .../cache/IgniteCacheInvokeAbstractTest.java | 1 - .../cache/IgniteTxExceptionAbstractSelfTest.java | 1 - .../cache/WithKeepBinaryCacheFullApiTest.java | 2 -- .../CacheLateAffinityAssignmentTest.java | 1 - .../distributed/IgniteTxCachePrimarySyncTest.java | 1 - .../GridCacheDhtEvictionNearReadersSelfTest.java | 1 - .../IgniteCachePutRetryTransactionalSelfTest.java | 1 - .../near/GridCacheNearMultiNodeSelfTest.java | 2 +- .../GridCacheNearOnlyMultiNodeFullApiSelfTest.java | 1 - .../near/GridCacheNearTxMultiNodeSelfTest.java | 1 - ...ridCachePartitionedMultiNodeCounterSelfTest.java | 2 +- .../cache/eviction/EvictionAbstractTest.java | 2 -- .../eviction/EvictionPolicyFactoryAbstractTest.java | 4 ---- .../GridCacheLocalTxMultiThreadedSelfTest.java | 1 - .../memtracker/PageMemoryTrackerPluginProvider.java | 2 -- .../continuous/CacheContinuousBatchAckTest.java | 1 - .../CacheContinuousQueryCounterAbstractTest.java | 1 - .../CacheContinuousQueryEventBufferTest.java | 1 - .../transactions/AbstractDeadlockDetectionTest.java | 1 - .../cache/transactions/TxDeadlockCauseTest.java | 1 - .../TxDeadlockDetectionUnmasrhalErrorsTest.java | 1 - ...xPessimisticDeadlockDetectionCrossCacheTest.java | 1 - .../closure/GridClosureProcessorSelfTest.java | 1 - .../processors/igfs/IgfsAbstractBaseSelfTest.java | 1 - .../IpcSharedMemoryCrashDetectionSelfTest.java | 2 +- .../org/apache/ignite/lang/IgniteUuidSelfTest.java | 1 - .../ignite/loadtests/GridLoadTestStatistics.java | 1 - .../ignite/loadtests/GridSingleExecutionTest.java | 1 - .../loadtests/cache/GridCacheAbstractLoadTest.java | 2 -- .../redeploy/GridSingleSplitsRedeployLoadTest.java | 1 - .../apache/ignite/loadtests/dsi/GridDsiClient.java | 2 +- .../apache/ignite/loadtests/dsi/GridDsiPerfJob.java | 1 - .../marshaller/GridMarshallerAbstractTest.java | 1 - .../ignite/messaging/GridMessagingSelfTest.java | 1 - .../p2p/GridAbstractMultinodeRedeployTest.java | 1 - .../ignite/p2p/GridP2PDoubleDeploymentSelfTest.java | 1 - .../p2p/GridP2PRemoteClassLoadersSelfTest.java | 1 - .../apache/ignite/p2p/GridP2PTimeoutSelfTest.java | 1 - .../apache/ignite/p2p/GridP2PUndeploySelfTest.java | 2 -- .../spi/collision/GridTestCollisionTaskSession.java | 1 - .../GridPriorityQueueCollisionSpiSelfTest.java | 3 +-- .../GridTcpCommunicationSpiRecoveryAckSelfTest.java | 2 -- .../GridTcpCommunicationSpiRecoverySelfTest.java | 1 - ...eTcpCommunicationRecoveryAckClosureSelfTest.java | 2 -- .../tcp/TcpClientDiscoverySpiSelfTest.java | 1 - .../always/GridAlwaysFailoverSpiSelfTest.java | 1 - .../GridJobStealingFailoverSpiSelfTest.java | 1 - .../apache/ignite/startup/GridVmNodesStarter.java | 1 - .../ignite/testframework/GridSpiTestContext.java | 2 -- .../apache/ignite/testframework/GridTestNode.java | 2 +- .../apache/ignite/testframework/GridTestUtils.java | 1 - .../ConfigVariationsTestSuiteBuilder.java | 2 -- .../testframework/configvariations/Parameters.java | 5 ----- .../testframework/junits/GridAbstractTest.java | 4 +--- .../IgniteCacheConfigVariationsAbstractTest.java | 2 -- .../testframework/junits/IgniteTestResources.java | 1 - .../junits/cache/TestCacheSession.java | 2 -- .../junits/cache/TestThreadLocalCacheSession.java | 2 -- .../junits/common/GridCommonAbstractTest.java | 5 ----- .../junits/multijvm/IgniteCacheProcessProxy.java | 1 - .../junits/spi/GridSpiAbstractTest.java | 3 --- 292 files changed, 40 insertions(+), 604 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/idea/ignite_inspections_teamcity.xml ---------------------------------------------------------------------- diff --git a/idea/ignite_inspections_teamcity.xml b/idea/ignite_inspections_teamcity.xml index 759b138..3b58d3a 100644 --- a/idea/ignite_inspections_teamcity.xml +++ b/idea/ignite_inspections_teamcity.xml @@ -121,6 +121,7 @@ <inspection_tool class="CanBeParameter" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CanBePrimaryConstructorProperty" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CanBeVal" enabled="false" level="WARNING" enabled_by_default="false"/> + <inspection_tool class="CastCanBeRemovedNarrowingVariableType" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="CastConflictsWithInstanceof" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CastThatLosesPrecision" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CastToConcreteClass" enabled="false" level="WARNING" enabled_by_default="false"/> @@ -132,6 +133,7 @@ <inspection_tool class="ChannelResource" enabled="false" level="WARNING" enabled_by_default="false"> <option name="insideTryAllowed" value="false"/> </inspection_tool> + <inspection_tool class="CharsetObjectCanBeUsed" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="CharUsedInArithmeticContext" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CharacterComparison" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CheckDtdRefs" enabled="false" level="ERROR" enabled_by_default="false"/> @@ -203,6 +205,8 @@ <option name="IGNORE_NON_PUBLIC" value="true"/> </inspection_tool> <inspection_tool class="ComponentRegistrationProblems" enabled="false" level="ERROR" enabled_by_default="false"/> + <inspection_tool class="ConditionalBreakInInfiniteLoop" enabled="false" level="WARNING" enabled_by_default="false" /> + <inspection_tool class="ConditionCoveredByFurtherCondition" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="ConditionSignal" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="ConditionalExpression" enabled="false" level="WARNING" enabled_by_default="false"> <option name="ignoreSimpleAssignmentsAndReturns" value="false"/> @@ -256,6 +260,7 @@ <inspection_tool class="ConvertJavadoc" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="ConvertOldAnnotations" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="ConvertToStringTemplate" enabled="false" level="INFO" enabled_by_default="false"/> + <inspection_tool class="CopyConstructorMissesField" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="CovariantCompareTo" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CovariantEquals" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="CyclicClassDependency" enabled="false" level="WARNING" enabled_by_default="false"/> @@ -301,6 +306,7 @@ <inspection_tool class="DuplicateCondition" enabled="false" level="WARNING" enabled_by_default="false"> <option name="ignoreMethodCalls" value="false"/> </inspection_tool> + <inspection_tool class="DuplicateExpressions" enabled="false" level="WEAK WARNING" enabled_by_default="false"/> <inspection_tool class="DuplicateMnemonic" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="DuplicatePropertyInspection" enabled="false" level="WARNING" enabled_by_default="false"> <option name="CURRENT_FILE" value="true"/> @@ -943,6 +949,9 @@ <option name="IGNORE_ANNOTATED_METHODS" value="true"/> <option name="IGNORE_SUSPICIOUS_METHOD_CALLS" value="true"/> </inspection_tool> + <inspection_tool class="RedundantClassCall" enabled="false" level="WARNING" enabled_by_default="false"/> + <inspection_tool class="RedundantCollectionOperation" enabled="false" level="WARNING" enabled_by_default="false"/> + <inspection_tool class="RedundantCompareCall" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="RedundantFieldInitialization" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="RedundantImplements" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="RedundantLambdaParameterType" enabled="false" level="INFORMATION" enabled_by_default="false"/> @@ -1076,6 +1085,7 @@ <option name="processLiterals" value="true"/> <option name="processComments" value="true"/> </inspection_tool> + <inspection_tool class="SortedCollectionWithNonComparableKeys" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="SpringAopErrorsInspection" enabled="false" level="ERROR" enabled_by_default="false"/> <inspection_tool class="SpringAopWarningsInspection" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="SpringBatchModel" enabled="false" level="ERROR" enabled_by_default="false"/> @@ -1125,6 +1135,7 @@ <inspection_tool class="SpringTransactionalComponentInspection" enabled="false" level="ERROR" enabled_by_default="false"/> <inspection_tool class="SpringWebServiceAnnotationsInconsistencyInspection" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="SpringWebServicesConfigurationsInspection" enabled="false" level="ERROR" enabled_by_default="false"/> + <inspection_tool class="SpringXmlModelInspection" enabled="false" level="ERROR" enabled_by_default="false"/> <inspection_tool class="SqlAddNotNullColumnInspection" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="SqlAmbiguousColumnInspection" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="SqlAutoIncrementDuplicateInspection" enabled="false" level="WARNING" enabled_by_default="false"/> @@ -1251,6 +1262,7 @@ <inspection_tool class="ThrowableNotThrown" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="ThrowablePrintedToSystemOut" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="ThrowableResultOfMethodCallIgnored" enabled="false" level="WARNING" enabled_by_default="false" /> + <inspection_tool class="ToArrayCallWithZeroLengthArrayArgument" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="TrivialIf" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="TryFinallyCanBeTryWithResources" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="TryStatementWithMultipleResources" enabled="false" level="INFORMATION" enabled_by_default="false" /> @@ -1404,6 +1416,7 @@ <inspection_tool class="WhileLoopSpinsOnField" enabled="false" level="WARNING" enabled_by_default="false"> <option name="ignoreNonEmtpyLoops" value="false"/> </inspection_tool> + <inspection_tool class="WrapperTypeMayBePrimitive" enabled="false" level="WARNING" enabled_by_default="false"/> <inspection_tool class="WrongImportPackage" enabled="false" level="ERROR" enabled_by_default="false"/> <inspection_tool class="WrongPackageStatement" enabled="false" level="ERROR" enabled_by_default="false"/> <inspection_tool class="WrongPropertyKeyValueDelimiter" enabled="false" level="WEAK WARNING" enabled_by_default="false"/> http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java index 610ff99..05c37a5 100644 --- a/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java +++ b/modules/core/src/main/java/org/apache/ignite/IgniteJdbcThinDataSource.java @@ -63,7 +63,6 @@ public class IgniteJdbcThinDataSource implements DataSource, Serializable { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T unwrap(Class<T> iface) throws SQLException { if (!isWrapperFor(iface)) throw new SQLException("DataSource is not a wrapper for " + iface.getName()); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/cache/CacheManager.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cache/CacheManager.java b/modules/core/src/main/java/org/apache/ignite/cache/CacheManager.java index b376755..7b6b4dd 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/CacheManager.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/CacheManager.java @@ -148,7 +148,6 @@ public class CacheManager implements javax.cache.CacheManager { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V, C extends Configuration<K, V>> Cache<K, V> createCache(String cacheName, C cacheCfg) throws IllegalArgumentException { kernalGateway.readLock(); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/cache/affinity/AffinityKey.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cache/affinity/AffinityKey.java b/modules/core/src/main/java/org/apache/ignite/cache/affinity/AffinityKey.java index 4215b05..054ff13 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/affinity/AffinityKey.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/affinity/AffinityKey.java @@ -127,7 +127,6 @@ public class AffinityKey<K> implements Externalizable { * * @return Affinity key to use for affinity mapping. */ - @SuppressWarnings({"unchecked"}) public <T> T affinityKey() { A.notNull(key, "key"); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/cache/eviction/fifo/FifoEvictionPolicy.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cache/eviction/fifo/FifoEvictionPolicy.java b/modules/core/src/main/java/org/apache/ignite/cache/eviction/fifo/FifoEvictionPolicy.java index f6e1a15..b634bd0 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/eviction/fifo/FifoEvictionPolicy.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/eviction/fifo/FifoEvictionPolicy.java @@ -115,7 +115,6 @@ public class FifoEvictionPolicy<K, V> extends AbstractEvictionPolicy<K, V> imple } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override protected boolean removeMeta(Object meta) { return queue.unlinkx((Node<EvictableEntry<K, V>>)meta); } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/cache/eviction/lru/LruEvictionPolicy.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cache/eviction/lru/LruEvictionPolicy.java b/modules/core/src/main/java/org/apache/ignite/cache/eviction/lru/LruEvictionPolicy.java index d571e8c..57b4395 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/eviction/lru/LruEvictionPolicy.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/eviction/lru/LruEvictionPolicy.java @@ -103,7 +103,6 @@ public class LruEvictionPolicy<K, V> extends AbstractEvictionPolicy<K, V> implem } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override protected boolean removeMeta(Object meta) { return queue.unlinkx((Node<EvictableEntry<K, V>>)meta); } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/cache/eviction/sorted/SortedEvictionPolicy.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/cache/eviction/sorted/SortedEvictionPolicy.java b/modules/core/src/main/java/org/apache/ignite/cache/eviction/sorted/SortedEvictionPolicy.java index 02a6d2b..f189e08 100644 --- a/modules/core/src/main/java/org/apache/ignite/cache/eviction/sorted/SortedEvictionPolicy.java +++ b/modules/core/src/main/java/org/apache/ignite/cache/eviction/sorted/SortedEvictionPolicy.java @@ -244,7 +244,6 @@ public class SortedEvictionPolicy<K, V> extends AbstractEvictionPolicy<K, V> imp } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException { super.readExternal(in); @@ -256,7 +255,6 @@ public class SortedEvictionPolicy<K, V> extends AbstractEvictionPolicy<K, V> imp * * @param meta Holder. */ - @SuppressWarnings("unchecked") @Override protected boolean removeMeta(Object meta) { Holder<K, V> holder = (Holder<K, V>)meta; @@ -297,7 +295,6 @@ public class SortedEvictionPolicy<K, V> extends AbstractEvictionPolicy<K, V> imp } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public boolean equals(Object obj) { if (this == obj) return true; @@ -353,7 +350,6 @@ public class SortedEvictionPolicy<K, V> extends AbstractEvictionPolicy<K, V> imp private static final long serialVersionUID = 0L; /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public int compare(Holder<K, V> h1, Holder<K, V> h2) { if (h1 == h2) return 0; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/compute/ComputeJobAdapter.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/compute/ComputeJobAdapter.java b/modules/core/src/main/java/org/apache/ignite/compute/ComputeJobAdapter.java index 3d1c308..cd23021 100644 --- a/modules/core/src/main/java/org/apache/ignite/compute/ComputeJobAdapter.java +++ b/modules/core/src/main/java/org/apache/ignite/compute/ComputeJobAdapter.java @@ -109,7 +109,6 @@ public abstract class ComputeJobAdapter implements ComputeJob, Callable<Object> * @throws NullPointerException Thrown in case when there no arguments set. * @throws IllegalArgumentException Thrown if index is invalid. */ - @SuppressWarnings("unchecked") @Nullable public <T> T argument(int idx) { A.notNull(args, "args"); A.ensure(idx >= 0 && idx < args.length, "idx >= 0 && idx < args.length"); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java b/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java index e27961d..10cbedd 100644 --- a/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java +++ b/modules/core/src/main/java/org/apache/ignite/configuration/CacheConfiguration.java @@ -798,7 +798,6 @@ public class CacheConfiguration<K, V> extends MutableConfiguration<K, V> { * * @return Eviction filter or {@code null}. */ - @SuppressWarnings("unchecked") public EvictionFilter<K, V> getEvictionFilter() { return (EvictionFilter<K, V>)evictFilter; } @@ -895,7 +894,6 @@ public class CacheConfiguration<K, V> extends MutableConfiguration<K, V> { * * @return Cache store factory. */ - @SuppressWarnings("unchecked") public Factory<CacheStore<? super K, ? super V>> getCacheStoreFactory() { return (Factory<CacheStore<? super K, ? super V>>)storeFactory; } @@ -906,7 +904,6 @@ public class CacheConfiguration<K, V> extends MutableConfiguration<K, V> { * @param storeFactory Cache store factory. * @return {@code this} for chaining. */ - @SuppressWarnings("unchecked") public CacheConfiguration<K, V> setCacheStoreFactory( Factory<? extends CacheStore<? super K, ? super V>> storeFactory) { this.storeFactory = storeFactory; @@ -1040,7 +1037,6 @@ public class CacheConfiguration<K, V> extends MutableConfiguration<K, V> { * @param atomicityMode Cache atomicity mode. * @return {@code this} for chaining. */ - @SuppressWarnings("unchecked") public CacheConfiguration<K, V> setAtomicityMode(CacheAtomicityMode atomicityMode) { this.atomicityMode = atomicityMode; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/events/CacheEvent.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/events/CacheEvent.java b/modules/core/src/main/java/org/apache/ignite/events/CacheEvent.java index 92b2ade..7a4d24d 100644 --- a/modules/core/src/main/java/org/apache/ignite/events/CacheEvent.java +++ b/modules/core/src/main/java/org/apache/ignite/events/CacheEvent.java @@ -229,7 +229,6 @@ public class CacheEvent extends EventAdapter { * * @return Cache entry associated with event. */ - @SuppressWarnings({"unchecked"}) public <K> K key() { return (K)key; } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/igfs/secondary/local/LocalIgfsSecondaryFileSystem.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/igfs/secondary/local/LocalIgfsSecondaryFileSystem.java b/modules/core/src/main/java/org/apache/ignite/igfs/secondary/local/LocalIgfsSecondaryFileSystem.java index f5ddb1c..17cc076 100644 --- a/modules/core/src/main/java/org/apache/ignite/igfs/secondary/local/LocalIgfsSecondaryFileSystem.java +++ b/modules/core/src/main/java/org/apache/ignite/igfs/secondary/local/LocalIgfsSecondaryFileSystem.java @@ -137,7 +137,6 @@ public class LocalIgfsSecondaryFileSystem implements IgfsSecondaryFileSystem, Li } /** {@inheritDoc} */ - @SuppressWarnings("ConstantConditions") @Override public boolean delete(IgfsPath path, boolean recursive) { File f = fileForPath(path); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java index 409a3d2..6fe54b2 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/AsyncSupportAdapter.java @@ -45,7 +45,6 @@ public class AsyncSupportAdapter<T extends IgniteAsyncSupport> implements Ignite } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public T withAsync() { if (isAsync()) return (T)this; @@ -79,7 +78,6 @@ public class AsyncSupportAdapter<T extends IgniteAsyncSupport> implements Ignite * * @return Future for previous asynchronous operation. */ - @SuppressWarnings("unchecked") public <R> IgniteFuture<R> future(boolean reset) { if (curFut == null) throw new IllegalStateException("Asynchronous mode is disabled."); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/GridJobContextImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridJobContextImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/GridJobContextImpl.java index dbfa0b1..b4b2be7 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridJobContextImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridJobContextImpl.java @@ -137,7 +137,6 @@ public class GridJobContextImpl implements ComputeJobContext, Externalizable { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V> V getAttribute(K key) { A.notNull(key, "key"); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/GridKernalContextImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridKernalContextImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/GridKernalContextImpl.java index 4b4fbca..8131899 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridKernalContextImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridKernalContextImpl.java @@ -852,7 +852,6 @@ public class GridKernalContextImpl implements GridKernalContext, Externalizable } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V> DataStreamProcessor<K, V> dataStream() { return (DataStreamProcessor<K, V>)dataLdrProc; } @@ -980,7 +979,6 @@ public class GridKernalContextImpl implements GridKernalContext, Externalizable } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <T> T createComponent(Class<T> cls) { T res = pluginProc.createComponent(cls); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/GridTaskSessionImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/GridTaskSessionImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/GridTaskSessionImpl.java index ce6e831..88091ea 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/GridTaskSessionImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/GridTaskSessionImpl.java @@ -285,7 +285,6 @@ public class GridTaskSessionImpl implements GridTaskSessionInternal { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V> V waitForAttribute(K key, long timeout) throws InterruptedException { A.notNull(key, "key"); @@ -549,7 +548,6 @@ public class GridTaskSessionImpl implements GridTaskSessionInternal { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V> V getAttribute(K key) { A.notNull(key, "key"); @@ -727,7 +725,6 @@ public class GridTaskSessionImpl implements GridTaskSessionInternal { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T loadCheckpoint(String key) { return loadCheckpoint0(this, key); } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/IgniteComponentType.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteComponentType.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteComponentType.java index 65cbb90..190ff9a 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteComponentType.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteComponentType.java @@ -242,7 +242,6 @@ public enum IgniteComponentType { * @return Created component or no-op implementation. * @throws IgniteCheckedException If failed. */ - @SuppressWarnings("unchecked") private <T> T createOptional0(@Nullable GridKernalContext ctx) throws IgniteCheckedException { Class<?> cls; @@ -283,7 +282,6 @@ public enum IgniteComponentType { * @return Component instance. * @throws IgniteCheckedException If failed. */ - @SuppressWarnings("unchecked") private <T> T create0(@Nullable GridKernalContext ctx, String clsName) throws IgniteCheckedException { try { Class<?> cls = Class.forName(clsName); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/IgniteComputeImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteComputeImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteComputeImpl.java index 762d9a1..c1809fe 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteComputeImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteComputeImpl.java @@ -453,7 +453,6 @@ public class IgniteComputeImpl extends AsyncSupportAdapter<IgniteCompute> } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T, R> R execute(String taskName, @Nullable T arg) { try { return (R)saveOrGet(executeAsync0(taskName, arg)); @@ -475,7 +474,6 @@ public class IgniteComputeImpl extends AsyncSupportAdapter<IgniteCompute> * @param arg Argument. * @return Internal future. */ - @SuppressWarnings("unchecked") private <T, R> IgniteInternalFuture<R> executeAsync0(String taskName, @Nullable T arg) { A.notNull(taskName, "taskName"); @@ -515,7 +513,6 @@ public class IgniteComputeImpl extends AsyncSupportAdapter<IgniteCompute> * @param arg Argument. * @return Internal future. */ - @SuppressWarnings("unchecked") private <T, R> IgniteInternalFuture<R> executeAsync0(Class<? extends ComputeTask<T, R>> taskCls, @Nullable T arg) { A.notNull(taskCls, "taskCls"); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/IgniteEventsImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteEventsImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteEventsImpl.java index 030e2db..c91792d 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteEventsImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteEventsImpl.java @@ -195,7 +195,6 @@ public class IgniteEventsImpl extends AsyncSupportAdapter<IgniteEvents> implemen } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public IgniteFuture<Void> stopRemoteListenAsync(UUID opId) throws IgniteException { A.notNull(opId, "consumeId"); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java index d1d0ce5..cc0363c 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java @@ -660,7 +660,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public List<String> getUserAttributesFormatted() { assert cfg != null; @@ -774,7 +773,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { * @param hnd Default uncaught exception handler used by thread pools. * @throws IgniteCheckedException Thrown in case of any errors. */ - @SuppressWarnings({"unchecked"}) public void start( final IgniteConfiguration cfg, ExecutorService utilityCachePool, @@ -1460,7 +1458,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { * @param notifyEnabled Update notifier flag. * @throws IgniteCheckedException thrown if was unable to set up attribute. */ - @SuppressWarnings({"unchecked", "TypeMayBeWeakened"}) private void fillNodeAttributes(boolean notifyEnabled) throws IgniteCheckedException { ctx.addNodeAttribute(ATTR_REBALANCE_POOL_SIZE, configuration().getRebalanceThreadPoolSize()); ctx.addNodeAttribute(ATTR_DATA_STREAMER_POOL_SIZE, configuration().getDataStreamerThreadPoolSize()); @@ -2817,7 +2814,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public String executeTask(String taskName, String arg) throws JMException { try { return compute().execute(taskName, arg); @@ -3008,7 +3004,6 @@ public class IgniteKernal implements IgniteEx, IgniteMXBean, Externalizable { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V> IgniteBiTuple<IgniteCache<K, V>, Boolean> getOrCreateCache0( CacheConfiguration<K, V> cacheCfg, boolean sql) { A.notNull(cacheCfg, "cacheCfg"); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/IgniteServicesImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgniteServicesImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/IgniteServicesImpl.java index 7cbd4b5..59d6136 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgniteServicesImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgniteServicesImpl.java @@ -41,7 +41,6 @@ import org.jetbrains.annotations.Nullable; /** * {@link org.apache.ignite.IgniteServices} implementation. */ -@SuppressWarnings("unchecked") public class IgniteServicesImpl extends AsyncSupportAdapter implements IgniteServices, Externalizable { /** */ private static final long serialVersionUID = 0L; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java b/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java index adc0068..559b3bb 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java @@ -1749,7 +1749,6 @@ public class IgnitionEx { * @param startCtx Starting context. * @throws IgniteCheckedException If start failed. */ - @SuppressWarnings({"TooBroadScope"}) private void start0(GridStartContext startCtx) throws IgniteCheckedException { assert grid == null : "Grid is already started: " + name; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumCache.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumCache.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumCache.java index 895782e..ae8b824 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumCache.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumCache.java @@ -37,7 +37,6 @@ public class BinaryEnumCache { * @return Value. * @throws BinaryObjectException In case of invalid ordinal. */ - @SuppressWarnings("unchecked") public static <T> T get(Class<?> cls, int ord) throws BinaryObjectException { assert cls != null; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumObjectImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumObjectImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumObjectImpl.java index 2751695..dd99787 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumObjectImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryEnumObjectImpl.java @@ -174,7 +174,6 @@ public class BinaryEnumObjectImpl implements BinaryObjectEx, Externalizable, Cac } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T deserialize() throws BinaryObjectException { Class cls = BinaryUtils.resolveClass(ctx, typeId, clsName, ctx.configuration().getClassLoader(), true); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryFieldImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryFieldImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryFieldImpl.java index de0b2d0..7713f58 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryFieldImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryFieldImpl.java @@ -102,7 +102,6 @@ public class BinaryFieldImpl implements BinaryFieldEx { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T value(BinaryObject obj) { BinaryObjectExImpl obj0 = (BinaryObjectExImpl)obj; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectExImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectExImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectExImpl.java index f213ad9..51599f8 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectExImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectExImpl.java @@ -247,7 +247,6 @@ public abstract class BinaryObjectExImpl implements BinaryObjectEx { * @param ctx Reader context. * @param handles Handles for already traversed objects. */ - @SuppressWarnings("unchecked") private void appendValue(Object val, SB buf, BinaryReaderHandles ctx, IdentityHashMap<BinaryObject, Integer> handles) { if (val instanceof byte[]) http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectImpl.java index 65fb349..3081f4f 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectImpl.java @@ -135,7 +135,6 @@ public final class BinaryObjectImpl extends BinaryObjectExImpl implements Extern } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <T> T value(CacheObjectValueContext ctx, boolean cpy) { Object obj0 = obj; @@ -303,13 +302,11 @@ public final class BinaryObjectImpl extends BinaryObjectExImpl implements Extern } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <F> F field(String fieldName) throws BinaryObjectException { return (F) reader(null, false).unmarshalField(fieldName); } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <F> F field(int fieldId) throws BinaryObjectException { return (F) reader(null, false).unmarshalField(fieldId); } @@ -352,7 +349,6 @@ public final class BinaryObjectImpl extends BinaryObjectExImpl implements Extern } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <F> F fieldByOrder(int order) { if (order == BinarySchema.ORDER_NOT_FOUND) return null; @@ -504,7 +500,6 @@ public final class BinaryObjectImpl extends BinaryObjectExImpl implements Extern } /** {@inheritDoc} */ - @SuppressWarnings("IfMayBeConditional") @Override public boolean writeFieldByOrder(int order, ByteBuffer buf) { // Calculate field position. int schemaOffset = BinaryPrimitives.readInt(arr, start + GridBinaryMarshaller.SCHEMA_OR_RAW_OFF_POS); @@ -621,7 +616,6 @@ public final class BinaryObjectImpl extends BinaryObjectExImpl implements Extern } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override protected <F> F field(BinaryReaderHandles rCtx, String fieldName) { return (F)reader(rCtx, false).unmarshalField(fieldName); } @@ -632,7 +626,6 @@ public final class BinaryObjectImpl extends BinaryObjectExImpl implements Extern } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <T> T deserialize() throws BinaryObjectException { Object obj0 = obj; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java index 7063c56..6f0176c 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectOffheapImpl.java @@ -197,13 +197,11 @@ public class BinaryObjectOffheapImpl extends BinaryObjectExImpl implements Exter } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <F> F field(String fieldName) throws BinaryObjectException { return (F) reader(null, false).unmarshalField(fieldName); } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <F> F field(int fieldId) throws BinaryObjectException { return (F) reader(null, false).unmarshalField(fieldId); } @@ -246,7 +244,6 @@ public class BinaryObjectOffheapImpl extends BinaryObjectExImpl implements Exter } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <F> F fieldByOrder(int order) { if (order == BinarySchema.ORDER_NOT_FOUND) return null; @@ -408,7 +405,6 @@ public class BinaryObjectOffheapImpl extends BinaryObjectExImpl implements Exter } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override protected <F> F field(BinaryReaderHandles rCtx, String fieldName) { return (F)reader(rCtx, false).unmarshalField(fieldName); } @@ -419,7 +415,6 @@ public class BinaryObjectOffheapImpl extends BinaryObjectExImpl implements Exter } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <T> T deserialize() throws BinaryObjectException { return (T)deserializeValue(); } @@ -445,7 +440,6 @@ public class BinaryObjectOffheapImpl extends BinaryObjectExImpl implements Exter } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <T> T value(CacheObjectValueContext ctx, boolean cpy) { return (T)deserializeValue(); } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderExImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderExImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderExImpl.java index 601141c..9d44e3c 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderExImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderExImpl.java @@ -1307,7 +1307,6 @@ public class BinaryReaderExImpl implements BinaryReader, BinaryRawReaderEx, Bina } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <T> T readObject(String fieldName) throws BinaryObjectException { try { return findFieldByName(fieldName) ? (T)BinaryUtils.doReadObject(in, ctx, ldr, this) : null; @@ -2311,13 +2310,11 @@ public class BinaryReaderExImpl implements BinaryReader, BinaryRawReaderEx, Bina } /** {@inheritDoc} */ - @SuppressWarnings("NullableProblems") @Override public void readFully(byte[] b) throws IOException { readFully(b, 0, b.length); } /** {@inheritDoc} */ - @SuppressWarnings("NullableProblems") @Override public void readFully(byte[] b, int off, int len) throws IOException { int cnt = in.read(b, off, len); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderHandles.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderHandles.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderHandles.java index 27a9918..f3ee443 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderHandles.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryReaderHandles.java @@ -50,7 +50,6 @@ public class BinaryReaderHandles { * @param pos Position. * @return Object. */ - @SuppressWarnings("unchecked") @Nullable public <T> T get(int pos) { switch (mode) { case MODE_EMPTY: http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeMap.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeMap.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeMap.java index 3dae8ce..3fa30fa 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeMap.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryTreeMap.java @@ -57,7 +57,6 @@ public class BinaryTreeMap implements Binarylizable, Serializable { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public void writeBinary(BinaryWriter writer) throws BinaryObjectException { BinaryRawWriter rawWriter = writer.rawWriter(); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java index 77dce56..640cf1b 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java @@ -656,7 +656,6 @@ public class BinaryUtils { * @param map Map. * @return New map of the same type or null. */ - @SuppressWarnings("unchecked") public static <K, V> Map<K, V> newKnownMap(Object map) { Class<?> cls = map == null ? null : map.getClass(); @@ -748,7 +747,6 @@ public class BinaryUtils { * @param col Collection. * @return New empty collection. */ - @SuppressWarnings("unchecked") public static <V> Collection<V> newKnownCollection(Object col) { Class<?> cls = col == null ? null : col.getClass(); @@ -1074,7 +1072,6 @@ public class BinaryUtils { * @param cls Class. * @return Mode. */ - @SuppressWarnings("IfMayBeConditional") public static BinaryWriteMode mode(Class<?> cls) { assert cls != null; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java index d882b17..29f8e73 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java @@ -1736,7 +1736,6 @@ public class BinaryWriterExImpl implements BinaryWriter, BinaryRawWriterEx, Obje } /** {@inheritDoc} */ - @SuppressWarnings("NullableProblems") @Override public void writeBytes(String s) throws IOException { int len = s.length(); @@ -1747,7 +1746,6 @@ public class BinaryWriterExImpl implements BinaryWriter, BinaryRawWriterEx, Obje } /** {@inheritDoc} */ - @SuppressWarnings("NullableProblems") @Override public void writeChars(String s) throws IOException { int len = s.length(); @@ -1758,7 +1756,6 @@ public class BinaryWriterExImpl implements BinaryWriter, BinaryRawWriterEx, Obje } /** {@inheritDoc} */ - @SuppressWarnings("NullableProblems") @Override public void writeUTF(String s) throws IOException { writeString(s); } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterHandles.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterHandles.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterHandles.java index 3be3898..2cbce96 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterHandles.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterHandles.java @@ -51,7 +51,6 @@ public class BinaryWriterHandles { * @param pos Position. * @return Old position. */ - @SuppressWarnings("unchecked") public int put(Object obj, int pos) { assert obj != null; assert pos >= 0; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/GridBinaryMarshaller.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/GridBinaryMarshaller.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/GridBinaryMarshaller.java index 7439589..aca48ea 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/GridBinaryMarshaller.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/GridBinaryMarshaller.java @@ -262,7 +262,6 @@ public class GridBinaryMarshaller { * @return Binary object. * @throws org.apache.ignite.binary.BinaryObjectException In case of error. */ - @SuppressWarnings("unchecked") @Nullable public <T> T unmarshal(byte[] bytes, @Nullable ClassLoader clsLdr) throws BinaryObjectException { assert bytes != null; @@ -281,7 +280,6 @@ public class GridBinaryMarshaller { * @return Binary object. * @throws org.apache.ignite.binary.BinaryObjectException In case of error. */ - @SuppressWarnings("unchecked") @Nullable public <T> T unmarshal(BinaryInputStream in) throws BinaryObjectException { BinaryContext oldCtx = pushContext(ctx); @@ -299,7 +297,6 @@ public class GridBinaryMarshaller { * @return Deserialized object. * @throws org.apache.ignite.binary.BinaryObjectException In case of error. */ - @SuppressWarnings("unchecked") @Nullable public <T> T deserialize(byte[] arr, @Nullable ClassLoader ldr) throws BinaryObjectException { assert arr != null; assert arr.length > 0; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java index ce3807d..a21e74b 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/binary/builder/BinaryObjectBuilderImpl.java @@ -531,7 +531,6 @@ public class BinaryObjectBuilderImpl implements BinaryObjectBuilder { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T getField(String name) { Object val; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientDataImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientDataImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientDataImpl.java index a2a9754..21c09c2 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientDataImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientDataImpl.java @@ -256,7 +256,6 @@ public class GridClientDataImpl extends GridClientAbstractProjection<GridClientD } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K> UUID affinity(K key) throws GridClientException { A.notNull(key, "key"); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientNodeImpl.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientNodeImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientNodeImpl.java index 4365c45..2be1bce 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientNodeImpl.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/impl/GridClientNodeImpl.java @@ -145,7 +145,6 @@ public class GridClientNodeImpl implements GridClientNode { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Nullable @Override public <T> T attribute(String name) { return (T)attrs.get(name); } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/client/marshaller/jdk/GridClientJdkMarshaller.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/marshaller/jdk/GridClientJdkMarshaller.java b/modules/core/src/main/java/org/apache/ignite/internal/client/marshaller/jdk/GridClientJdkMarshaller.java index bd89e80..dc59254 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/marshaller/jdk/GridClientJdkMarshaller.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/marshaller/jdk/GridClientJdkMarshaller.java @@ -76,7 +76,6 @@ public class GridClientJdkMarshaller implements GridClientMarshaller { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T unmarshal(byte[] bytes) throws IOException { ByteArrayInputStream tmp = new ByteArrayInputStream(bytes); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientBinary.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientBinary.java b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientBinary.java index 6024f55..4655cbf 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientBinary.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientBinary.java @@ -50,7 +50,6 @@ class ClientBinary implements IgniteBinary { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T toBinary(Object obj) { if (obj == null) return null; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientUtils.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientUtils.java b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientUtils.java index d218e45..8e2d61a 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientUtils.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientUtils.java @@ -496,7 +496,6 @@ final class ClientUtils { } /** Read Ignite binary object from input stream. */ - @SuppressWarnings("unchecked") <T> T readObject(BinaryInputStream in, boolean keepBinary) { Object val = marsh.unmarshal(in); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java index 2da3b8f..b60b618 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientCache.java @@ -375,7 +375,6 @@ class TcpClientCache<K, V> implements ClientCache<K, V> { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K1, V1> ClientCache<K1, V1> withKeepBinary() { TcpClientCache<K1, V1> binCache; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/client/util/GridConcurrentHashSet.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/util/GridConcurrentHashSet.java b/modules/core/src/main/java/org/apache/ignite/internal/client/util/GridConcurrentHashSet.java index 44fa209..3225a4a 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/client/util/GridConcurrentHashSet.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/client/util/GridConcurrentHashSet.java @@ -45,7 +45,6 @@ public class GridConcurrentHashSet<E> extends AbstractSet<E> { * * @param map Map to be used for set implementation. */ - @SuppressWarnings({"unchecked"}) public GridConcurrentHashSet(ConcurrentMap<E, ?> map) { this.map = (ConcurrentMap<E, Object>)map; } @@ -55,7 +54,6 @@ public class GridConcurrentHashSet<E> extends AbstractSet<E> { * * @return Wrapped map. */ - @SuppressWarnings({"unchecked"}) protected final <T extends Map<E, Object>> T map() { return (T)map; } http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/direct/state/DirectMessageState.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/direct/state/DirectMessageState.java b/modules/core/src/main/java/org/apache/ignite/internal/direct/state/DirectMessageState.java index 58f625f..b92f600 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/direct/state/DirectMessageState.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/direct/state/DirectMessageState.java @@ -44,7 +44,6 @@ public class DirectMessageState<T extends DirectMessageStateItem> { * @param cls State item type. * @param factory Item factory. */ - @SuppressWarnings("unchecked") public DirectMessageState(Class<T> cls, IgniteOutClosure<T> factory) { this.factory = factory; @@ -63,7 +62,6 @@ public class DirectMessageState<T extends DirectMessageStateItem> { /** * Go forward. */ - @SuppressWarnings("unchecked") public void forward() { pos++; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v1/DirectByteBufferStreamImplV1.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v1/DirectByteBufferStreamImplV1.java b/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v1/DirectByteBufferStreamImplV1.java index 118e1f1..75ac038 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v1/DirectByteBufferStreamImplV1.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v1/DirectByteBufferStreamImplV1.java @@ -584,7 +584,6 @@ public class DirectByteBufferStreamImplV1 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V> void writeMap(Map<K, V> map, MessageCollectionItemType keyType, MessageCollectionItemType valType, MessageWriter writer) { if (map != null) { @@ -823,7 +822,6 @@ public class DirectByteBufferStreamImplV1 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T extends Message> T readMessage(MessageReader reader) { if (!msgTypeDone) { if (buf.remaining() < Message.DIRECT_TYPE_SIZE) { @@ -867,7 +865,6 @@ public class DirectByteBufferStreamImplV1 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T[] readObjectArray(MessageCollectionItemType itemType, Class<T> itemCls, MessageReader reader) { if (readSize == -1) { @@ -907,7 +904,6 @@ public class DirectByteBufferStreamImplV1 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <C extends Collection<?>> C readCollection(MessageCollectionItemType itemType, MessageReader reader) { if (readSize == -1) { @@ -947,7 +943,6 @@ public class DirectByteBufferStreamImplV1 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <M extends Map<?, ?>> M readMap(MessageCollectionItemType keyType, MessageCollectionItemType valType, boolean linked, MessageReader reader) { if (readSize == -1) { @@ -1056,7 +1051,6 @@ public class DirectByteBufferStreamImplV1 implements DirectByteBufferStream { * @param off Base offset. * @return Array or special value if it was not fully read. */ - @SuppressWarnings("unchecked") private <T> T readArray(ArrayCreator<T> creator, int lenShift, long off) { assert creator != null; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v2/DirectByteBufferStreamImplV2.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v2/DirectByteBufferStreamImplV2.java b/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v2/DirectByteBufferStreamImplV2.java index fd93cfb..ef6e01f 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v2/DirectByteBufferStreamImplV2.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v2/DirectByteBufferStreamImplV2.java @@ -788,7 +788,6 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <K, V> void writeMap(Map<K, V> map, MessageCollectionItemType keyType, MessageCollectionItemType valType, MessageWriter writer) { if (map != null) { @@ -1164,7 +1163,6 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T extends Message> T readMessage(MessageReader reader) { if (!msgTypeDone) { if (buf.remaining() < Message.DIRECT_TYPE_SIZE) { @@ -1208,7 +1206,6 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T[] readObjectArray(MessageCollectionItemType itemType, Class<T> itemCls, MessageReader reader) { if (readSize == -1) { @@ -1248,7 +1245,6 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <C extends Collection<?>> C readCollection(MessageCollectionItemType itemType, MessageReader reader) { if (readSize == -1) { @@ -1288,7 +1284,6 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <M extends Map<?, ?>> M readMap(MessageCollectionItemType keyType, MessageCollectionItemType valType, boolean linked, MessageReader reader) { if (readSize == -1) { @@ -1466,7 +1461,6 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream { * @param off Base offset. * @return Array or special value if it was not fully read. */ - @SuppressWarnings("unchecked") <T> T readArray(ArrayCreator<T> creator, int lenShift, long off) { assert creator != null; @@ -1530,7 +1524,6 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream { * @param off Base offset. * @return Array or special value if it was not fully read. */ - @SuppressWarnings("unchecked") <T> T readArrayLE(ArrayCreator<T> creator, int typeSize, int lenShift, long off) { assert creator != null; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/igfs/common/IgfsControlResponse.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/igfs/common/IgfsControlResponse.java b/modules/core/src/main/java/org/apache/ignite/internal/igfs/common/IgfsControlResponse.java index 2614cf7..2ad8dbe 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/igfs/common/IgfsControlResponse.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/igfs/common/IgfsControlResponse.java @@ -388,7 +388,6 @@ public class IgfsControlResponse extends IgfsMessage { * @param out Data output. * @throws IOException If error occurred. */ - @SuppressWarnings("unchecked") public void writeExternal(ObjectOutput out) throws IOException { byte[] hdr = new byte[RES_HEADER_SIZE]; http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/jdbc/JdbcResultSet.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/JdbcResultSet.java b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/JdbcResultSet.java index 544207e..9a6a388 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/JdbcResultSet.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/JdbcResultSet.java @@ -1502,7 +1502,6 @@ public class JdbcResultSet implements ResultSet { * @return Casted field value. * @throws SQLException In case of error. */ - @SuppressWarnings("unchecked") private <T> T getTypedValue(int colIdx, Class<T> cls) throws SQLException { ensureNotClosed(); ensureHasCurrentRow(); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinConnection.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinConnection.java b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinConnection.java index 6878c8f..110cc74 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinConnection.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinConnection.java @@ -654,7 +654,6 @@ public class JdbcThinConnection implements Connection { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T unwrap(Class<T> iface) throws SQLException { if (!isWrapperFor(iface)) throw new SQLException("Connection is not a wrapper for " + iface.getName()); @@ -739,7 +738,6 @@ public class JdbcThinConnection implements Connection { * @return Server response. * @throws SQLException On any error. */ - @SuppressWarnings("unchecked") <R extends JdbcResult> R sendRequest(JdbcRequest req) throws SQLException { ensureConnected(); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java index f79b16d..d1a5f6d 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java @@ -1502,7 +1502,6 @@ public class JdbcThinDatabaseMetadata implements DatabaseMetaData { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T unwrap(Class<T> iface) throws SQLException { if (!isWrapperFor(iface)) throw new SQLException("Database meta data is not a wrapper for " + iface.getName()); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinParameterMetadata.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinParameterMetadata.java b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinParameterMetadata.java index 8647258..093637b 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinParameterMetadata.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinParameterMetadata.java @@ -86,7 +86,6 @@ public class JdbcThinParameterMetadata implements ParameterMetaData { } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T unwrap(Class<T> iface) throws SQLException { if (!isWrapperFor(iface)) throw new SQLException("Parameters metadata is not a wrapper for " + iface.getName()); http://git-wip-us.apache.org/repos/asf/ignite/blob/ad9d5610/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinPreparedStatement.java ---------------------------------------------------------------------- diff --git a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinPreparedStatement.java b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinPreparedStatement.java index d18788c..b9ed4ba 100644 --- a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinPreparedStatement.java +++ b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinPreparedStatement.java @@ -507,7 +507,6 @@ public class JdbcThinPreparedStatement extends JdbcThinStatement implements Prep } /** {@inheritDoc} */ - @SuppressWarnings("unchecked") @Override public <T> T unwrap(Class<T> iface) throws SQLException { if (!isWrapperFor(iface)) throw new SQLException("Prepared statement is not a wrapper for " + iface.getName());
