This is an automated email from the ASF dual-hosted git repository.

vozerov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git


The following commit(s) were added to refs/heads/master by this push:
     new d620268  Removed irrelevant TODOs.
d620268 is described below

commit d6202689f421bd4ccf293650acc3a83d438f537e
Author: devozerov <[email protected]>
AuthorDate: Thu Feb 14 11:13:22 2019 +0300

    Removed irrelevant TODOs.
---
 .../ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java   | 2 --
 1 file changed, 2 deletions(-)

diff --git 
a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
 
b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
index 406c323..e3fca3c 100644
--- 
a/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
+++ 
b/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/sql/GridSqlQuerySplitter.java
@@ -1194,7 +1194,6 @@ public class GridSqlQuerySplitter {
 
         // -- HAVING
         if (havingCol >= 0 && !collocatedGrpBy) {
-            // TODO IGNITE-1140 - Find aggregate functions in HAVING clause or 
rewrite query to put all aggregates to SELECT clause.
             // We need to find HAVING column in reduce query.
             for (int i = visibleCols; i < rdcQry.allColumns(); i++) {
                 GridSqlAst c = rdcQry.column(i);
@@ -1217,7 +1216,6 @@ public class GridSqlQuerySplitter {
             // If collocatedGrpBy is true, then aggregateFound is always false.
             if (aggregateFound) // Ordering over aggregates does not make 
sense.
                 mapQry.clearSort(); // Otherwise map sort will be used by 
offset-limit.
-            // TODO IGNITE-1141 - Check if sorting is done over aggregated 
expression, otherwise we can sort and use offset-limit.
         }
 
         // -- LIMIT

Reply via email to