This is an automated email from the ASF dual-hosted git repository.
amashenkov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new c4d3d82 IGNITE-16469: Fix mentions for SQL resolved tickets (#627)
c4d3d82 is described below
commit c4d3d8200344555fa3813f48ce3e1f7a5160d8a7
Author: ygerzhedovich <[email protected]>
AuthorDate: Thu Feb 3 18:29:43 2022 +0300
IGNITE-16469: Fix mentions for SQL resolved tickets (#627)
---
.../ignite/schema/definition/ColumnDefinition.java | 2 +-
.../runner/app/jdbc/ItJdbcConnectionSelfTest.java | 2 --
.../internal/sql/engine/ItMixedQueriesTest.java | 24 +++-------------------
.../table/RecordBinaryViewOperationsTest.java | 4 ++--
4 files changed, 6 insertions(+), 26 deletions(-)
diff --git
a/modules/api/src/main/java/org/apache/ignite/schema/definition/ColumnDefinition.java
b/modules/api/src/main/java/org/apache/ignite/schema/definition/ColumnDefinition.java
index 6da286f..e0178db 100644
---
a/modules/api/src/main/java/org/apache/ignite/schema/definition/ColumnDefinition.java
+++
b/modules/api/src/main/java/org/apache/ignite/schema/definition/ColumnDefinition.java
@@ -47,6 +47,6 @@ public interface ColumnDefinition {
*
* @return Default column value expression.
*/
- //TODO: IGNITE-15341 Rename to defaultValueExpr or allow constants? How to
distinct expression from string constant???
+ //TODO: IGNITE-14479: Rename to defaultValueExpr or allow constants? How
to distinct expression from string constant???
Object defaultValue();
}
diff --git
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/jdbc/ItJdbcConnectionSelfTest.java
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/jdbc/ItJdbcConnectionSelfTest.java
index 5615f36..99e7c7c 100644
---
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/jdbc/ItJdbcConnectionSelfTest.java
+++
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/jdbc/ItJdbcConnectionSelfTest.java
@@ -974,8 +974,6 @@ public class ItJdbcConnectionSelfTest extends
AbstractJdbcSelfTest {
@Test
public void testGetSetClientInfoPair() throws Exception {
- // fail("https://issues.apache.org/jira/browse/IGNITE-5425";);
-
try (Connection conn = DriverManager.getConnection(URL)) {
final String name = "ApplicationName";
final String val = "SelfTest";
diff --git
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItMixedQueriesTest.java
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItMixedQueriesTest.java
index 14d8dac..fe1ace1 100644
---
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItMixedQueriesTest.java
+++
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItMixedQueriesTest.java
@@ -208,13 +208,12 @@ public class ItMixedQueriesTest extends
AbstractBasicIntegrationTest {
assertEquals(1, rows.size());
}
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-15107";)
@Test
public void testSequentialInserts() {
- sql("CREATE TABLE t(x INTEGER)");
+ sql("CREATE TABLE t(x INTEGER PRIMARY KEY, y int)");
for (int i = 0; i < 10_000; i++) {
- sql("INSERT INTO t VALUES (?)", i);
+ sql("INSERT INTO t VALUES (?,?)", i, i);
}
assertEquals(10_000L, sql("SELECT count(*) FROM t").get(0).get(0));
@@ -306,32 +305,15 @@ public class ItMixedQueriesTest extends
AbstractBasicIntegrationTest {
* 2) result set returned will be sorted as expected.
*/
@Test
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-15107";)
+ @Disabled("https://issues.apache.org/jira/browse/IGNITE-14925";)
public void testSelectWithOrdering() {
// sql("drop table if exists test_tbl", true);
// sql("create table test_tbl (c1 int)", true);
// sql("insert into test_tbl values (1), (2), (3), (null)", true);
- // TODO: support indexes.
https://issues.apache.org/jira/browse/IGNITE-14925
// sql("create index idx_asc on test_tbl (c1)", true);
// sql("create index idx_desc on test_tbl (c1 desc)", true);
- createTable(
- SchemaBuilders.tableBuilder("PUBLIC", "TEST_TBL").columns(
- SchemaBuilders.column("ID", ColumnType.INT32).build(),
- SchemaBuilders.column("C1",
ColumnType.INT32).asNullable(true).build()
- ).withPrimaryKey("ID")
- );
-
- insertData(
- "PUBLIC.TEST_TBL",
- new String[] {"ID", "C1"},
- new Object[] {0, 1},
- new Object[] {0, 2},
- new Object[] {0, 3},
- new Object[] {0, null}
- );
-
assertQuery("select c1 from test_tbl ORDER BY c1")
// .matches(containsIndexScan("PUBLIC", "TEST_TBL", "IDX_ASC"))
// .matches(not(containsSubPlan("IgniteSort")))
diff --git
a/modules/table/src/test/java/org/apache/ignite/internal/table/RecordBinaryViewOperationsTest.java
b/modules/table/src/test/java/org/apache/ignite/internal/table/RecordBinaryViewOperationsTest.java
index 13d8a33..abed93e 100644
---
a/modules/table/src/test/java/org/apache/ignite/internal/table/RecordBinaryViewOperationsTest.java
+++
b/modules/table/src/test/java/org/apache/ignite/internal/table/RecordBinaryViewOperationsTest.java
@@ -53,10 +53,10 @@ import org.mockito.Mockito;
/**
* Basic table operations test.
- *
- * <p>TODO: IGNITE-14486 Add tests for invoke operations. Add tests for bulk
operations. Add tests for async operations.
*/
public class RecordBinaryViewOperationsTest {
+ //TODO: IGNITE-16468 Extend test coverage.
+
@Test
public void insert() {
SchemaDescriptor schema = new SchemaDescriptor(
