This is an automated email from the ASF dual-hosted git repository.

ptupitsyn pushed a commit to branch ignite-14972
in repository https://gitbox.apache.org/repos/asf/ignite-3.git


The following commit(s) were added to refs/heads/ignite-14972 by this push:
     new e5c48bff4 wip TODOs
e5c48bff4 is described below

commit e5c48bff40daba75da4635ddf3d88e27ad359690
Author: Pavel Tupitsyn <[email protected]>
AuthorDate: Thu May 26 13:54:37 2022 +0300

    wip TODOs
---
 .../ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
 
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
index 191922a72..b38c71ba5 100644
--- 
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
+++ 
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
@@ -62,8 +62,8 @@ public class ClientSqlExecuteRequest {
             sessionBuilder.property(in.unpackString(), 
in.unpackObjectWithType());
         }
 
-        // TODO: Session must be somehow stored on the server, to be able to 
close it and clean up.
-        // So build call on the client must perform a network call.
+        // Session simply tracks active queries. We don't need to store it in 
resources.
+        // Instead, we track active queries in the ClientSession and close 
them there accordingly.
         Session session = sessionBuilder.build();
 
         // TODO: should we store prepared statements per connection? - 
separate ticket.

Reply via email to