This is an automated email from the ASF dual-hosted git repository.
ptupitsyn pushed a commit to branch ignite-14972
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/ignite-14972 by this push:
new 7c0537740 Add ColumnMetadataImpl
7c0537740 is described below
commit 7c0537740ba4eede9b23ea7a2b4ce8be60d46bab
Author: Pavel Tupitsyn <[email protected]>
AuthorDate: Mon May 30 20:47:42 2022 +0300
Add ColumnMetadataImpl
---
.../client/handler/requests/sql/ClientSqlExecuteRequest.java | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
index b574777f5..434e200e4 100644
---
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
+++
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlExecuteRequest.java
@@ -20,6 +20,7 @@ package org.apache.ignite.client.handler.requests.sql;
import static
org.apache.ignite.client.handler.requests.sql.ClientSqlCommon.packCurrentPage;
import static
org.apache.ignite.client.handler.requests.table.ClientTableCommon.readTx;
+import java.util.List;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;
import org.apache.ignite.client.handler.ClientResource;
@@ -28,6 +29,7 @@ import
org.apache.ignite.internal.client.proto.ClientMessagePacker;
import org.apache.ignite.internal.client.proto.ClientMessageUnpacker;
import org.apache.ignite.lang.IgniteInternalCheckedException;
import org.apache.ignite.lang.IgniteInternalException;
+import org.apache.ignite.sql.ColumnMetadata;
import org.apache.ignite.sql.IgniteSql;
import org.apache.ignite.sql.Session;
import org.apache.ignite.sql.Session.SessionBuilder;
@@ -75,10 +77,7 @@ public class ClientSqlExecuteRequest {
out.packLong(asyncResultSet.affectedRows());
// Pack metadata.
- // TODO: IGNITE-17052
- out.packArrayHeader(0);
-
- /** if (asyncResultSet.metadata() == null ||
asyncResultSet.metadata().columns() == null) {
+ if (asyncResultSet.metadata() == null ||
asyncResultSet.metadata().columns() == null) {
out.packArrayHeader(0);
} else {
List<ColumnMetadata> cols =
asyncResultSet.metadata().columns();
@@ -89,12 +88,12 @@ public class ClientSqlExecuteRequest {
out.packString(col.name());
out.packBoolean(col.nullable());
- // TODO: IGNITE-16962 SQL API: Implement query metadata.
+ // TODO: IGNITE-17052 Implement query metadata.
// Ideally we only need the type code here.
out.packString(col.valueClass().getName());
out.packObjectWithType(col.type());
}
- }*/
+ }
// Pack first page.
if (asyncResultSet.hasRowSet()) {